From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Kyungmin Park' <kmpark@infradead.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
'Seungwhan Youn' <sw.youn@samsung.com>
Subject: RE: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330
Date: Thu, 21 Oct 2010 11:36:13 +0900 [thread overview]
Message-ID: <030201cb70c8$bc7f4aa0$357ddfe0$%kim@samsung.com> (raw)
In-Reply-To: <AANLkTi=ZTBuPBDL4MZ7MPn3Ha_cNhyShosyzn8q6QF3N@mail.gmail.com>
Kyungmin Park wrote:
>
> On Thu, Oct 21, 2010 at 9:58 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > From: Seungwhan Youn <sw.youn@samsung.com>
> >
> > This patch adds to enable/disable DMA operation clock on S3C-PL330
> > DMA controller driver.
>
> The title and description seems to clock gating but actual code is
> just enable at probe and disable at remove.
>
> Can you make it REAL clock gating, enable clock only when using?
>
This is just to move DMA enable/disable clock into DMA driver(S3C PL330).
So it would be better if we could discuss about what you said next time.
Basically, I prefer most clocks should be registered as disabled, then if
required enable, just should be controlled in each driver.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-10-21 2:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 0:58 [PATCH 0/5] ARM: S5P: Update DMA operation clock Kukjin Kim
2010-10-21 0:58 ` [PATCH 1/5] ARM: S5P6442: Add " Kukjin Kim
2010-10-21 22:22 ` Ben Dooks
2010-10-22 5:20 ` Kukjin Kim
2010-10-21 0:58 ` [PATCH 2/5] ARM: S5PV210: " Kukjin Kim
2010-10-21 0:58 ` [PATCH 3/5] ARM: S5P64X0: Set DMA clock disable as default Kukjin Kim
2010-10-21 0:58 ` [PATCH 4/5] ARM: S5P: Reorder DMA platform device id Kukjin Kim
2010-10-21 0:58 ` [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330 Kukjin Kim
2010-10-21 1:32 ` Kyungmin Park
2010-10-21 1:45 ` Jassi Brar
2010-10-21 1:49 ` Kyungmin Park
2010-10-21 1:54 ` Jassi Brar
2010-10-21 2:12 ` Kyungmin Park
2010-10-21 2:19 ` Jassi Brar
2010-10-21 2:41 ` Kukjin Kim
2010-10-21 2:36 ` Kukjin Kim [this message]
2010-10-21 3:54 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='030201cb70c8$bc7f4aa0$357ddfe0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw.youn@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox