RE: [PATCH 5/5] ARM: SAMSUNG: Add to enable/disable clock on S3C PL330

[Kukjin Kim <kgene.kim@samsung.com>]

Jassi Brar wrote:
> 
> On Thu, Oct 21, 2010 at 10:49 AM, Kyungmin Park <kmpark@infradead.org> wrote:
> >>> Can you make it REAL clock gating, enable clock only when using?
> >>
> >> Of course we can. But that will need some intrusive changes.
> >> Later, we'll implement that desirable feature.
> >> For now, many SoCs don't detect PL330 since the clocks are gated
> >> by default and we don't enable them in driver. So, this is just to get
> >> latest SoCs' PL330 working.
> >
> > I see even though I don't know "later" is how much
> 
> We (apparently) don't have fixed policy about which devices have their clocks
> enabled by default and which don't.
> So, by default PL330 clock is enabled on some platforms and not on others.
> This patch only makes sure the PL330 works on all platforms at boot-time.
> 
> 
> > and include the s5pc210 code also at this patchset.
> Yes, all platforms should be enabled for PL330 driver.

If we want to use S5PV310/S5PC210 DMA now, need implementation some stuff of it.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.