From: Krzysztof Kozlowski <krzk@kernel.org>
To: Petr Vorel <pvorel@suse.cz>
Cc: linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/1] samsung: Sort Makefile
Date: Fri, 10 Nov 2023 09:06:25 +0100 [thread overview]
Message-ID: <058278b4-d959-4c28-9f9e-cffde46dac70@kernel.org> (raw)
In-Reply-To: <20231110063456.GB1536739@pevik>
On 10/11/2023 07:34, Petr Vorel wrote:
> Hi Krzysztof,
>
>> On 09/11/2023 17:38, Krzysztof Kozlowski wrote:
>>> On 08/11/2023 10:01, Petr Vorel wrote:
>>>> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>>>> ---
>
>> You also lack commit msg explaining why doing this.
> I'm sorry, I thought the reason is obvious - readability.
>
> Some Makefiles are tried to be sorted (e.g. drivers/clk/qcom/Makefile),
> but lots of them are not (drivers/net/Makefile). Anyway, it's up to you (and
> other maintainers) to judge if it's useful or not. If considered useful, I'll
> send v2.
>
The commit should come with message justifying it. It's also not clear
what do you sort - entries are sorted by Kconfig, but you move
CONFIG_EXYNOS_5250_COMMON_CLK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-10 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 9:01 [PATCH 1/1] samsung: Sort Makefile Petr Vorel
2023-11-09 16:38 ` Krzysztof Kozlowski
2023-11-09 16:39 ` Krzysztof Kozlowski
2023-11-10 6:34 ` Petr Vorel
2023-11-10 8:06 ` Krzysztof Kozlowski [this message]
2023-11-10 9:46 ` Petr Vorel
2023-11-10 6:25 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=058278b4-d959-4c28-9f9e-cffde46dac70@kernel.org \
--to=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox