From: Krzysztof Kozlowski <krzk@kernel.org>
To: Petr Vorel <pvorel@suse.cz>, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/1] samsung: Sort Makefile
Date: Thu, 9 Nov 2023 17:39:35 +0100 [thread overview]
Message-ID: <f7dd78c9-2020-4874-a49e-02a782dcb2a4@kernel.org> (raw)
In-Reply-To: <4d95c252-b992-4214-8cc8-5c98bf07259f@kernel.org>
On 09/11/2023 17:38, Krzysztof Kozlowski wrote:
> On 08/11/2023 10:01, Petr Vorel wrote:
>> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>> ---
You also lack commit msg explaining why doing this.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-09 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 9:01 [PATCH 1/1] samsung: Sort Makefile Petr Vorel
2023-11-09 16:38 ` Krzysztof Kozlowski
2023-11-09 16:39 ` Krzysztof Kozlowski [this message]
2023-11-10 6:34 ` Petr Vorel
2023-11-10 8:06 ` Krzysztof Kozlowski
2023-11-10 9:46 ` Petr Vorel
2023-11-10 6:25 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7dd78c9-2020-4874-a49e-02a782dcb2a4@kernel.org \
--to=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox