From: Tomasz Figa <tomasz.figa@gmail.com>
To: Romain Naour <romain.naour@openwide.fr>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Kukjin Kim" <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
"'Sylwester Nawrocki'" <sylvester.nawrocki@gmail.com>
Subject: Re: [PATCH 0/5 v3] S3C / S5PC100: add clockevent/clocksource support
Date: Thu, 10 Jan 2013 01:14:02 +0100 [thread overview]
Message-ID: <10694299.cZC5vmGaMJ@flatron> (raw)
In-Reply-To: <50EDF297.4020908@openwide.fr>
Hi Romain, Kukjin,
On Wednesday 09 of January 2013 23:43:35 Romain Naour wrote:
> This series of patches converts the s3c and s5pc100 timer driver to the
> clocksource/clockevent API. I made some test on a mini2440 board and I
> had to reduce timers frequency to 1MHz in order to produce a timer's
> overflow every 64ms. Initial timer's frequency (8,45MHz) provide only
> 7ms between each overflow. It is not enough. As timers were previously
> used to produce an IRQ at 200Hz, some board (Osiris, Anubis board) use
> an external 12MHz signal to clock the timers (tclk1). So, I changed
> their configuration to select internal pclk clock instead, but I can't
> test it.
>
> Since clockevent/clocksource API becomes available, we can use High
> Resolution Timer and Tickless mode.
>
> Most of the work is already done in s5p-time.c (renamed samsung-time.c).
> I added some #define for s3c24xx and s5pc100 case.
>
>
> Naour Romain (5):
> Rename s5p-time to samsung-time
> Add samsung-time support for s3c24xx
> Add samsung-time support for s3c64xx
> Add samsung-time support for s5pc100
> Remove unused plat-samsung/time.c
>
> arch/arm/Kconfig | 9 +-
> arch/arm/mach-exynos/Kconfig | 2 +-
> arch/arm/mach-exynos/mach-universal_c210.c | 6 +-
> arch/arm/mach-s3c24xx/Kconfig | 6 +
> arch/arm/mach-s3c24xx/mach-amlm5900.c | 5 +-
> arch/arm/mach-s3c24xx/mach-anubis.c | 4 +-
> arch/arm/mach-s3c24xx/mach-at2440evb.c | 4 +-
> arch/arm/mach-s3c24xx/mach-bast.c | 4 +-
> arch/arm/mach-s3c24xx/mach-gta02.c | 4 +-
> arch/arm/mach-s3c24xx/mach-h1940.c | 5 +-
> arch/arm/mach-s3c24xx/mach-jive.c | 4 +-
> arch/arm/mach-s3c24xx/mach-mini2440.c | 4 +-
> arch/arm/mach-s3c24xx/mach-n30.c | 6 +-
> arch/arm/mach-s3c24xx/mach-nexcoder.c | 4 +-
> arch/arm/mach-s3c24xx/mach-osiris.c | 4 +-
> arch/arm/mach-s3c24xx/mach-otom.c | 4 +-
> arch/arm/mach-s3c24xx/mach-qt2410.c | 4 +-
> arch/arm/mach-s3c24xx/mach-rx1950.c | 4 +-
> arch/arm/mach-s3c24xx/mach-rx3715.c | 4 +-
> arch/arm/mach-s3c24xx/mach-smdk2410.c | 4 +-
> arch/arm/mach-s3c24xx/mach-smdk2413.c | 8 +-
> arch/arm/mach-s3c24xx/mach-smdk2416.c | 4 +-
> arch/arm/mach-s3c24xx/mach-smdk2440.c | 4 +-
> arch/arm/mach-s3c24xx/mach-smdk2443.c | 4 +-
> arch/arm/mach-s3c24xx/mach-tct_hammer.c | 4 +-
> arch/arm/mach-s3c24xx/mach-vr1000.c | 4 +-
> arch/arm/mach-s3c24xx/mach-vstms.c | 5 +-
> arch/arm/mach-s3c64xx/Kconfig | 2 +
> arch/arm/mach-s3c64xx/mach-anw6410.c | 4 +-
> arch/arm/mach-s3c64xx/mach-crag6410.c | 4 +-
> arch/arm/mach-s3c64xx/mach-hmt.c | 4 +-
> arch/arm/mach-s3c64xx/mach-mini6410.c | 4 +-
> arch/arm/mach-s3c64xx/mach-ncp.c | 4 +-
> arch/arm/mach-s3c64xx/mach-real6410.c | 4 +-
> arch/arm/mach-s3c64xx/mach-smartq.c | 2 +
> arch/arm/mach-s3c64xx/mach-smartq5.c | 3 +-
> arch/arm/mach-s3c64xx/mach-smartq7.c | 3 +-
> arch/arm/mach-s3c64xx/mach-smdk6400.c | 4 +-
> arch/arm/mach-s3c64xx/mach-smdk6410.c | 4 +-
> arch/arm/mach-s5p64x0/Kconfig | 4 +-
> arch/arm/mach-s5p64x0/mach-smdk6440.c | 6 +-
> arch/arm/mach-s5p64x0/mach-smdk6450.c | 6 +-
> arch/arm/mach-s5pc100/Kconfig | 1 +
> arch/arm/mach-s5pc100/mach-smdkc100.c | 4 +-
> arch/arm/mach-s5pv210/Kconfig | 2 +-
> arch/arm/mach-s5pv210/mach-aquila.c | 6 +-
> arch/arm/mach-s5pv210/mach-goni.c | 6 +-
> arch/arm/mach-s5pv210/mach-smdkc110.c | 6 +-
> arch/arm/mach-s5pv210/mach-smdkv210.c | 6 +-
> arch/arm/mach-s5pv210/mach-torbreck.c | 6 +-
> arch/arm/plat-samsung/Kconfig | 2 +-
> arch/arm/plat-samsung/Makefile | 3 +-
> arch/arm/plat-samsung/include/plat/cpu.h | 5 -
> arch/arm/plat-samsung/include/plat/s5p-time.h | 40 ---
> arch/arm/plat-samsung/include/plat/samsung-time.h | 51 ++++
> .../plat-samsung/{s5p-time.c => samsung-time.c} | 144 +++++------
> arch/arm/plat-samsung/time.c | 285
> --------------------- 57 files changed, 274 insertions(+), 475
> deletions(-)
> delete mode 100644 arch/arm/plat-samsung/include/plat/s5p-time.h
> create mode 100644 arch/arm/plat-samsung/include/plat/samsung-time.h
> rename arch/arm/plat-samsung/{s5p-time.c => samsung-time.c} (68%)
> delete mode 100644 arch/arm/plat-samsung/time.c
The whole series looks good to me.
Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
Also I tested it on a Tiny6410 (Mini6410-compatible) board.
Tested-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz Figa
next prev parent reply other threads:[~2013-01-10 0:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 20:56 [PATCH] S3C24XX: add clockevent/clocksource support Romain Naour
2012-10-25 20:39 ` Tomasz Figa
2012-10-26 10:51 ` Romain Naour
2012-11-23 2:30 ` Kukjin Kim
2012-11-25 2:54 ` Romain Naour
2012-11-25 11:09 ` Tomasz Figa
2012-11-27 23:27 ` [PATCH 1/3] Rename s5p-time to samsung-time Romain Naour
2012-11-27 23:57 ` Heiko Stübner
2012-11-29 23:18 ` Romain Naour
2012-11-29 23:59 ` Heiko Stübner
2012-12-02 19:43 ` [PATCH 0/5 v2] S3C / S5PC100: add clockevent/clocksource support Romain Naour
2012-12-02 19:44 ` [PATCH 1/5 v2] Rename s5p-time to samsung-time Romain Naour
2012-12-10 12:59 ` Heiko Stübner
2012-12-15 21:43 ` Romain Naour
2013-01-08 21:00 ` Tomasz Figa
2013-01-09 19:26 ` Kukjin Kim
2013-01-09 22:43 ` Romain Naour
2013-01-09 22:43 ` [PATCH 0/5 v3] S3C / S5PC100: add clockevent/clocksource support Romain Naour
2013-01-10 0:14 ` Tomasz Figa [this message]
2013-01-10 0:38 ` Kukjin Kim
2013-01-10 0:37 ` Heiko Stübner
2013-01-10 0:48 ` Kukjin Kim
2013-01-09 22:43 ` [PATCH 1/5 v3] Rename s5p-time to samsung-time Romain Naour
2013-01-09 22:43 ` [PATCH 2/5 v3] Add samsung-time support for s3c24xx Romain Naour
2013-01-10 3:03 ` Kukjin Kim
2013-01-09 22:44 ` [PATCH 3/5 v3] Add samsung-time support for s3c64xx Romain Naour
2013-01-09 22:44 ` [PATCH 4/5 v3] Add samsung-time support for s5pc100 Romain Naour
2013-01-09 22:44 ` [PATCH 5/5 v3] Remove unused plat-samsung/time.c Romain Naour
2012-12-02 19:44 ` [PATCH 2/5 v2] Add samsung-time support for s3c24xx Romain Naour
2012-12-10 13:00 ` Heiko Stübner
2012-12-15 21:40 ` Romain Naour
2012-12-02 19:44 ` [PATCH 3/5 v2] Add samsung-time support for s3c64xx Romain Naour
2012-12-02 19:44 ` [PATCH 4/5 v2] Add samsung-time support for s5pc100 Romain Naour
2012-12-02 19:44 ` [PATCH 5/5 v2] Remove unused plat-samsung/time.c Romain Naour
2012-12-10 12:57 ` Heiko Stübner
2012-12-15 21:40 ` Romain Naour
2012-12-15 21:40 ` [PATCH 5/5 v3] " Romain Naour
2012-11-27 23:27 ` [PATCH 2/3] Add samsung-time support for s3c24xx Romain Naour
2012-11-27 23:27 ` [PATCH 3/3] Add samsung-time support for s3c64xx Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10694299.cZC5vmGaMJ@flatron \
--to=tomasz.figa@gmail.com \
--cc=ben-linux@fluff.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=romain.naour@openwide.fr \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox