From: Ben Dooks <ben-linux@fluff.org>
To: linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org
Cc: Thomas Abraham <thomas.ab@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Ben Dooks <ben-linux@fluff.org>
Subject: [PATCH 06/11] USB: s3c-hsotg: Enable soft disconnect during initialization
Date: Wed, 26 May 2010 05:09:24 +0100 [thread overview]
Message-ID: <1274846966-23247-7-git-send-email-ben-linux@fluff.org> (raw)
In-Reply-To: <1274846966-23247-1-git-send-email-ben-linux@fluff.org>
From: Thomas Abraham <thomas.ab@samsung.com>
Enable soft disconnect bit the OTG core during initialization. Without this,
the host sees that a gadget is connected and tries to enumerate. The
soft disconnect should be enabled until the USB gadget driver is
registered with this otg driver.
Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
---
drivers/usb/gadget/s3c-hsotg.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index bce510c..7e595a4 100644
--- a/drivers/usb/gadget/s3c-hsotg.c
+++ b/drivers/usb/gadget/s3c-hsotg.c
@@ -2806,6 +2806,9 @@ static void s3c_hsotg_init(struct s3c_hsotg *hsotg)
writel(0, hsotg->regs + S3C_DAINTMSK);
+ /* Be in disconnected state until gadget is registered */
+ __orr32(hsotg->regs + S3C_DCTL, S3C_DCTL_SftDiscon);
+
if (0) {
/* post global nak until we're ready */
writel(S3C_DCTL_SGNPInNAK | S3C_DCTL_SGOUTNak,
--
1.6.3.3
next prev parent reply other threads:[~2010-05-26 4:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 4:09 s3c-hsotg driver updates/fixes Ben Dooks
2010-05-26 4:09 ` [PATCH 03/11] USB: s3c-hsotg: Ensure TX FIFO addresses setup when initialising FIFOs Ben Dooks
2010-05-26 4:09 ` Ben Dooks [this message]
[not found] ` <1274846966-23247-1-git-send-email-ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
2010-05-26 4:09 ` [PATCH 01/11] USB: s3c_hsotg: Add support for external USB clock Ben Dooks
2010-05-26 4:09 ` [PATCH 02/11] USB: s3c_hsotg: define USB_GADGET_DUALSPEED in Kconfig Ben Dooks
2010-05-26 4:09 ` [PATCH 04/11] USB: s3c-hsotg: SoftDisconnect minimum 3ms Ben Dooks
2010-05-26 4:09 ` [PATCH 05/11] USB: s3c-hsotg: Ensure FIFOs are fully flushed after layout Ben Dooks
2010-05-26 4:09 ` [PATCH 07/11] USB: s3c-hsotg: Increase TX fifo limit Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274846966-23247-7-git-send-email-ben-linux@fluff.org \
--to=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox