From: Tomasz Figa <tomasz.figa@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Grant Likely <grant.likely@linaro.org>,
linux-samsung-soc@vger.kernel.org,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] spi/s3c64xx: Remove unused message queue
Date: Sat, 06 Jul 2013 01:54:42 +0200 [thread overview]
Message-ID: <1866030.QlpeqFgIhJ@flatron> (raw)
In-Reply-To: <1373046993-1349-1-git-send-email-broonie@kernel.org>
On Friday 05 of July 2013 18:56:33 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Since the driver has been converted to use the core message pump code
> the only use of the messsage queue in the driver is a check to see if
> it is empty which will always succeed since nothing ever adds to the
> queue. Just remove the queue.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/spi/spi-s3c64xx.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
Looks good to me.
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2013-07-05 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 17:56 [PATCH] spi/s3c64xx: Remove unused message queue Mark Brown
2013-07-05 23:54 ` Tomasz Figa [this message]
2013-07-24 13:18 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1866030.QlpeqFgIhJ@flatron \
--to=tomasz.figa@gmail.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=grant.likely@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox