Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Viresh Kumar <viresh.kumar@st.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Lennert Buytenhek <kernel@wantstofly.org>,
	linux-samsung-soc@vger.kernel.org,
	"Hans J. Koch" <hjk@linutronix.de>,
	Scott Branden <sbranden@broadcom.com>,
	Tony Lindgren <tony@atomide.com>,
	David Brown <davidb@codeaurora.org>,
	Alessandro Rubini <rubini@unipv.it>,
	Jiandong Zheng <jdzheng@broadcom.com>,
	Wan ZongShun <mcuos.com@gmail.com>,
	linux-arm-msm@vger.kernel.org,
	STEricsson <STEricsson_nomadik_linux@list.st.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Daniel Walker <dwalker@codeaurora.org>,
	Eric Miao <eric.y.miao@gmail.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Erik Gilling <konkers@android.com>,
	Nicolas Pitre <nico@fluxnic.net>,
	Bryan Huntsman <bryanh@codeaurora.org>Sascha Hauer <kernel@>
Subject: Re: [PATCH 0/40] Complete set of clocksource/sched_clock patches
Date: Sun, 19 Dec 2010 14:49:50 +0000	[thread overview]
Message-ID: <20101219144950.GH3047@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <19726.4420.289089.490319@pilspetsen.it.uu.se>

On Sun, Dec 19, 2010 at 03:05:56PM +0100, Mikael Pettersson wrote:
> tmr = timer mode register
> tcr = timer counter register
> trr = timer reload register
> 
> When a timer is in periodic mode it reloads itself from its reload
> register when the counter register decrements to zero.

Ok.

>  >  Does trr need to be written in
>  > ->set_mode (if so that's another bug in this code)?
> 
> trr{0,1} need not and should not be changed after iop_time_init().

It sounds like trr0 needs to be written in ->set_mode's
CLOCK_EVT_MODE_PERIODIC path then, because with my patch, we never set
this register.  Or will trr0 be updated when we write tcr0 ?

  reply	other threads:[~2010-12-19 14:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-17 11:32 [PATCH 0/40] Complete set of clocksource/sched_clock patches Russell King - ARM Linux
2010-12-17 11:39 ` [PATCH 13/40] ARM: s5pv310: update clock source registration Russell King - ARM Linux
2010-12-19 10:37 ` [PATCH 0/40] Complete set of clocksource/sched_clock patches Mikael Pettersson
2010-12-19 10:52   ` Russell King - ARM Linux
2010-12-19 10:56     ` Russell King - ARM Linux
2010-12-19 12:16       ` Mikael Pettersson
2010-12-19 12:33     ` Mikael Pettersson
2010-12-19 12:55       ` Russell King - ARM Linux
2010-12-19 14:05         ` Mikael Pettersson
2010-12-19 14:49           ` Russell King - ARM Linux [this message]
2010-12-19 16:15             ` Mikael Pettersson
2010-12-20  3:32 ` Eric Miao
2010-12-20 22:48   ` Russell King - ARM Linux
2010-12-21 19:24 ` Kevin Hilman
2010-12-22  7:24 ` Olof Johansson
2010-12-22 10:59 ` Jamie Iles
2011-01-08  9:05 ` Wan ZongShun
2011-01-08  9:23   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101219144950.GH3047@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=STEricsson_nomadik_linux@list.st.com \
    --cc=bryanh@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=dwalker@codeaurora.org \
    --cc=eric.y.miao@gmail.com \
    --cc=hjk@linutronix.de \
    --cc=jdzheng@broadcom.com \
    --cc=kernel@wantstofly.org \
    --cc=kgene.kim@samsung.com \
    --cc=khilman@deeprootsystems.com \
    --cc=konkers@android.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mcuos.com@gmail.com \
    --cc=mikpe@it.uu.se \
    --cc=nico@fluxnic.net \
    --cc=rubini@unipv.it \
    --cc=sbranden@broadcom.com \
    --cc=tony@atomide.com \
    --cc=viresh.kumar@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox