Re: [PATCH 06/33] ARM: S3C24XX: dev-uart: Use common macro to define resources

["Heiko Stübner" <heiko@sntech.de>]

Am Mittwoch, 25. April 2012, 06:12:16 schrieb Tushar Behera:
> CC: Ben Dooks <ben-linux@fluff.org>
> CC: Kukjin Kim <kgene.kim@samsung.com>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>

Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  arch/arm/plat-s3c24xx/dev-uart.c |   56
> +++++++++++--------------------------- 1 files changed, 16 insertions(+),
> 40 deletions(-)
> 
> diff --git a/arch/arm/plat-s3c24xx/dev-uart.c
> b/arch/arm/plat-s3c24xx/dev-uart.c index 9ab22e6..d779216 100644
> --- a/arch/arm/plat-s3c24xx/dev-uart.c
> +++ b/arch/arm/plat-s3c24xx/dev-uart.c
> @@ -29,55 +29,31 @@
>  /* Serial port registrations */
> 
>  static struct resource s3c2410_uart0_resource[] = {
> -	[0] = {
> -		.start = S3C2410_PA_UART0,
> -		.end   = S3C2410_PA_UART0 + 0x3fff,
> -		.flags = IORESOURCE_MEM,
> -	},
> -	[1] = {
> -		.start = IRQ_S3CUART_RX0,
> -		.end   = IRQ_S3CUART_ERR0,
> -		.flags = IORESOURCE_IRQ,
> -	}
> +	[0] = DEFINE_RES_MEM(S3C2410_PA_UART0, SZ_16K),
> +	[1] = DEFINE_RES_NAMED(IRQ_S3CUART_RX0, \
> +			IRQ_S3CUART_ERR0 - IRQ_S3CUART_RX0 + 1, \
> +			NULL, IORESOURCE_IRQ)
>  };
> 
>  static struct resource s3c2410_uart1_resource[] = {
> -	[0] = {
> -		.start = S3C2410_PA_UART1,
> -		.end   = S3C2410_PA_UART1 + 0x3fff,
> -		.flags = IORESOURCE_MEM,
> -	},
> -	[1] = {
> -		.start = IRQ_S3CUART_RX1,
> -		.end   = IRQ_S3CUART_ERR1,
> -		.flags = IORESOURCE_IRQ,
> -	}
> +	[0] = DEFINE_RES_MEM(S3C2410_PA_UART1, SZ_16K),
> +	[1] = DEFINE_RES_NAMED(IRQ_S3CUART_RX1, \
> +			IRQ_S3CUART_ERR1 - IRQ_S3CUART_RX1 + 1, \
> +			NULL, IORESOURCE_IRQ)
>  };
> 
>  static struct resource s3c2410_uart2_resource[] = {
> -	[0] = {
> -		.start = S3C2410_PA_UART2,
> -		.end   = S3C2410_PA_UART2 + 0x3fff,
> -		.flags = IORESOURCE_MEM,
> -	},
> -	[1] = {
> -		.start = IRQ_S3CUART_RX2,
> -		.end   = IRQ_S3CUART_ERR2,
> -		.flags = IORESOURCE_IRQ,
> -	}
> +	[0] = DEFINE_RES_MEM(S3C2410_PA_UART2, SZ_16K),
> +	[1] = DEFINE_RES_NAMED(IRQ_S3CUART_RX2, \
> +			IRQ_S3CUART_ERR2 - IRQ_S3CUART_RX2 + 1, \
> +			NULL, IORESOURCE_IRQ)
>  };
> 
>  static struct resource s3c2410_uart3_resource[] = {
> -	[0] = {
> -		.start = S3C2443_PA_UART3,
> -		.end   = S3C2443_PA_UART3 + 0x3fff,
> -		.flags = IORESOURCE_MEM,
> -	},
> -	[1] = {
> -		.start = IRQ_S3CUART_RX3,
> -		.end   = IRQ_S3CUART_ERR3,
> -		.flags = IORESOURCE_IRQ,
> -	},
> +	[0] = DEFINE_RES_MEM(S3C2443_PA_UART3, SZ_16K),
> +	[1] = DEFINE_RES_NAMED(IRQ_S3CUART_RX3, \
> +			IRQ_S3CUART_ERR3 - IRQ_S3CUART_RX3 + 1, \
> +			NULL, IORESOURCE_IRQ)
>  };
> 
>  struct s3c24xx_uart_resources s3c2410_uart_resources[] __initdata = {