From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com,
linux@arm.linux.org.uk, Ben Dooks <ben-linux@fluff.org>,
patches@linaro.org
Subject: Re: [PATCH 16/33] ARM: S3C24XX: mach-osiris: Use common macro to define resources
Date: Wed, 25 Apr 2012 20:53:38 +0400 [thread overview]
Message-ID: <4F982C12.1020103@mvista.com> (raw)
In-Reply-To: <1335327163-11794-17-git-send-email-tushar.behera@linaro.org>
Hello.
On 04/25/2012 08:12 AM, Tushar Behera wrote:
> CC: Ben Dooks<ben-linux@fluff.org>
> CC: Kukjin Kim<kgene.kim@samsung.com>
> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
> ---
> arch/arm/mach-s3c24xx/mach-osiris.c | 12 ++----------
> 1 files changed, 2 insertions(+), 10 deletions(-)
> diff --git a/arch/arm/mach-s3c24xx/mach-osiris.c b/arch/arm/mach-s3c24xx/mach-osiris.c
> index c5daeb6..95d0772 100644
> --- a/arch/arm/mach-s3c24xx/mach-osiris.c
> +++ b/arch/arm/mach-s3c24xx/mach-osiris.c
> @@ -244,16 +244,8 @@ static struct s3c2410_platform_nand __initdata osiris_nand_info = {
> /* PCMCIA control and configuration */
>
> static struct resource osiris_pcmcia_resource[] = {
> - [0] = {
> - .start = 0x0f000000,
> - .end = 0x0f100000,
> - .flags = IORESOURCE_MEM,
> - },
> - [1] = {
> - .start = 0x0c000000,
> - .end = 0x0c100000,
> - .flags = IORESOURCE_MEM,
> - }
> + [0] = DEFINE_RES_MEM(0x0f000000, SZ_1M),
> + [1] = DEFINE_RES_MEM(0x0c000000, SZ_1M),
You seem to be fixing the mistake in the original code where - 1 was missing
in the '.end' initializers...
WBR, Sergei
next prev parent reply other threads:[~2012-04-25 16:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 4:12 [PATCH 00/33] Use common macro to define resources Tushar Behera
2012-04-25 4:12 ` [PATCH 01/33] ARM: SAMSUNG: devs: " Tushar Behera
2012-04-25 4:12 ` [PATCH 02/33] ARM: EXYNOS: dev-ahci: " Tushar Behera
2012-04-25 4:12 ` [PATCH 03/33] ARM: EXYNOS: dev-audio: " Tushar Behera
2012-04-25 4:12 ` [PATCH 04/33] ARM: EXYNOS: mach-armlex4210: " Tushar Behera
2012-04-25 4:12 ` [PATCH 05/33] ARM: EXYNOS: mach-smdkv310: " Tushar Behera
2012-04-25 4:12 ` [PATCH 06/33] ARM: S3C24XX: dev-uart: " Tushar Behera
2012-04-25 9:13 ` Heiko Stübner
2012-05-08 18:40 ` [PATCH v2 " Heiko Stübner
2012-05-09 12:44 ` Kukjin Kim
2012-04-25 4:12 ` [PATCH 07/33] ARM: S3C24XX: bast-ide: " Tushar Behera
2012-04-25 4:12 ` [PATCH 08/33] ARM: S3C24XX: mach-amlm5900: " Tushar Behera
2012-04-25 4:12 ` [PATCH 09/33] ARM: S3C24XX: mach-anubis: " Tushar Behera
2012-04-25 4:12 ` [PATCH 10/33] ARM: S3C24XX: mach-at2440evb: " Tushar Behera
2012-04-25 4:12 ` [PATCH 11/33] ARM: S3C24XX: mach-bast: " Tushar Behera
2012-04-25 4:12 ` [PATCH 12/33] ARM: S3C24XX: mach-gta02: " Tushar Behera
2012-04-25 4:12 ` [PATCH 13/33] ARM: S3C24XX: mach-h1940: " Tushar Behera
2012-04-25 4:12 ` [PATCH 14/33] ARM: S3C24XX: mach-mini2440: " Tushar Behera
2012-04-25 4:12 ` [PATCH 15/33] ARM: S3C24XX: mach-nexcoder: " Tushar Behera
2012-04-25 4:12 ` [PATCH 16/33] ARM: S3C24XX: mach-osiris: " Tushar Behera
2012-04-25 16:53 ` Sergei Shtylyov [this message]
2012-04-26 3:22 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 17/33] ARM: S3C24XX: mach-otom: " Tushar Behera
2012-04-25 4:12 ` [PATCH 18/33] ARM: S3C24XX: mach-qt2410: " Tushar Behera
2012-04-25 16:51 ` Sergei Shtylyov
2012-04-26 3:19 ` Tushar Behera
2012-04-25 4:12 ` [PATCH 19/33] ARM: S3C24XX: mach-rx1950: " Tushar Behera
2012-04-25 4:12 ` [PATCH 20/33] ARM: S3C24XX: mach-tct_hammer: " Tushar Behera
2012-04-25 4:12 ` [PATCH 21/33] ARM: S3C24XX: mach-vr1000: " Tushar Behera
2012-04-25 4:12 ` [PATCH 22/33] ARM: S3C24XX: simtec-nor: " Tushar Behera
2012-04-25 4:12 ` [PATCH 23/33] ARM: S3C64XX: dev-audio: " Tushar Behera
2012-04-25 4:12 ` [PATCH 24/33] ARM: S3C64XX: dev-uart: " Tushar Behera
2012-04-25 4:12 ` [PATCH 25/33] ARM: S3C64XX: mach-anw6410: " Tushar Behera
2012-04-25 4:12 ` [PATCH 26/33] ARM: S3C64XX: mach-crag6410: " Tushar Behera
2012-04-25 8:24 ` Mark Brown
2012-04-25 4:12 ` [PATCH 27/33] ARM: S3C64XX: mach-mini6410: " Tushar Behera
2012-04-25 4:12 ` [PATCH 28/33] ARM: S3C64XX: mach-real6410: " Tushar Behera
2012-04-25 4:12 ` [PATCH 29/33] ARM: S3C64XX: mach-smdk6410: " Tushar Behera
2012-04-25 4:12 ` [PATCH 30/33] ARM: S5P64X0: dev-audio: " Tushar Behera
2012-04-25 4:12 ` [PATCH 31/33] ARM: S5PC100: " Tushar Behera
2012-04-25 4:12 ` [PATCH 32/33] ARM: S5PV210: " Tushar Behera
2012-04-25 4:12 ` [PATCH 33/33] ARM: S5PV210: mach-smdkv210: " Tushar Behera
2012-04-25 4:19 ` [PATCH 00/33] " Jean-Christophe PLAGNIOL-VILLARD
2012-04-25 7:38 ` Heiko Stübner
2012-04-25 10:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-25 11:21 ` Arnd Bergmann
2012-04-25 11:35 ` Russell King - ARM Linux
2012-04-26 3:53 ` Tushar Behera
2012-05-09 12:55 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F982C12.1020103@mvista.com \
--to=sshtylyov@mvista.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox