re: [media] s5p-csis: Add support for non-image data packets capture

[Dan Carpenter <dan.carpenter@oracle.com>]

Hello Sylwester Nawrocki,

I had a question about 36fa80927638: "[media] s5p-csis: Add support for
non-image data packets capture" from Sep 21, 2012.

S5PCSIS_INTSRC_NON_IMAGE_DATA is defined in mipi-csis.c:

#define S5PCSIS_INTSRC_NON_IMAGE_DATA   (0xff << 28)

And it's only used in one place.

drivers/media/platform/exynos4-is/mipi-csis.c
   692          u32 status;
   693  
   694          status = s5pcsis_read(state, S5PCSIS_INTSRC);
   695          spin_lock_irqsave(&state->slock, flags);
   696  
   697          if ((status & S5PCSIS_INTSRC_NON_IMAGE_DATA) && pktbuf->data) {
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"status" is a u32 so 0xff0000000 is 4 bits too much.  In other words,
the mask is effectively "(0xf << 28)".  Was that intended or should it
be (0xff << 24)?

   698                  u32 offset;
   699  
   700                  if (status & S5PCSIS_INTSRC_EVEN)
   701                          offset = S5PCSIS_PKTDATA_EVEN;

regards,
dan carpenter