From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [media] s5p-csis: Add support for non-image data packets capture
Date: Fri, 23 Aug 2013 11:54:29 +0200 [thread overview]
Message-ID: <52173155.9090902@samsung.com> (raw)
In-Reply-To: <20130823093504.GJ31293@elgon.mountain>
On 08/23/2013 11:35 AM, Dan Carpenter wrote:
> Hello Sylwester Nawrocki,
>
> I had a question about 36fa80927638: "[media] s5p-csis: Add support for
> non-image data packets capture" from Sep 21, 2012.
>
> S5PCSIS_INTSRC_NON_IMAGE_DATA is defined in mipi-csis.c:
>
> #define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xff << 28)
This is supposed to be a mask for bits [31:28], so (0xf << 28)
> And it's only used in one place.
>
> drivers/media/platform/exynos4-is/mipi-csis.c
> 692 u32 status;
> 693
> 694 status = s5pcsis_read(state, S5PCSIS_INTSRC);
> 695 spin_lock_irqsave(&state->slock, flags);
> 696
> 697 if ((status & S5PCSIS_INTSRC_NON_IMAGE_DATA) && pktbuf->data) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> "status" is a u32 so 0xff0000000 is 4 bits too much. In other words,
> the mask is effectively "(0xf << 28)". Was that intended or should it
> be (0xff << 24)?
It should be (0xf << 28). Thanks for looking into this.
prev parent reply other threads:[~2013-08-23 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:35 [media] s5p-csis: Add support for non-image data packets capture Dan Carpenter
2013-08-23 9:54 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52173155.9090902@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox