From: Mark Brown <broonie@kernel.org>
To: Padma Venkat <padma.kvr@gmail.com>
Cc: alsa-devel@alsa-project.org,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Padmavathi Venna <padma.v@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Kukjin Kim <kgene.kim@samsung.com>,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 1/2] ASoC: samsung: Provide helper for DMA init
Date: Tue, 26 Nov 2013 10:15:02 +0000 [thread overview]
Message-ID: <20131126101502.GV14725@sirena.org.uk> (raw)
In-Reply-To: <CAAgF-BdUWGun6m2+zxMhUU1_DpZviHg-REnsGvh+bWgpm2NuLg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 595 bytes --]
On Tue, Nov 26, 2013 at 10:54:57AM +0530, Padma Venkat wrote:
> > - snd_soc_dai_init_dma_data(dai, &i2s->dma_playback, &i2s->dma_capture);
> > + samsung_asoc_init_dma_data(dai, &i2s->dma_playback, &i2s->dma_capture);
> we have to initialize the dma data for i2s secondary dai also
> otherwise there is a crash in dmaengine_pcm_new during probe.
This should be called when both DAIs are probed... in any case, if this
is broken presumably the driver is already broken given that this is
just a substitution? I've no systems capable of actually running audio
with the later DAIs.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-11-26 10:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 13:48 [PATCH 1/2] ASoC: samsung: Provide helper for DMA init Mark Brown
2013-11-12 13:48 ` [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible Mark Brown
2013-11-26 5:25 ` [alsa-devel] " Padma Venkat
2013-11-26 10:23 ` Mark Brown
2013-11-26 10:48 ` [alsa-devel] " Padma Venkat
2013-11-26 12:20 ` Mark Brown
2013-11-27 12:38 ` Padma Venkat
2013-11-27 15:05 ` Mark Brown
2013-11-28 9:59 ` [alsa-devel] " Padma Venkat
2013-11-28 11:53 ` Mark Brown
2013-12-05 10:50 ` [alsa-devel] " Padma Venkat
2013-12-05 11:45 ` Mark Brown
2013-12-09 17:52 ` Padma Venkat
2013-12-09 17:59 ` Mark Brown
2013-11-26 5:24 ` [alsa-devel] [PATCH 1/2] ASoC: samsung: Provide helper for DMA init Padma Venkat
2013-11-26 10:15 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-05 14:25 Mark Brown
2013-12-06 12:57 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126101502.GV14725@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kgene.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox