Re: [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1028 bytes --]

On Thu, Dec 05, 2013 at 04:20:03PM +0530, Padma Venkat wrote:
> On Thu, Nov 28, 2013 at 5:23 PM, Mark Brown <broonie@kernel.org> wrote:

> > OK, so we can probably just reinitialise the dmaengine data after we
> > reset it?  Like below

> Yes. That works well.

Great.

> As I forgot to add SND_DMAENGINE_PCM_FLAG_NO_RESIDUE flag, I was
> getting underrun error. After adding this flag audio playback is
> working fine for smaller files on smdk5420 with pl330 dma driver.

OK, there were some patches on the thread adding residue support to the
PL330 driver yesterday - hopefully those can get merged at some point

> Except for the crash due to NULL pointer dereference in secondary
> dai(I posted a patch for the same (ASoC: samsung: Initialize the
> dma_data for secondary dai)) you can add my

> Tested By: Padmavathi Venna <padma.v@samsung.com>

Excellent, thanks - I'd squashed in your change already.  Like I say I'm
still concerned that we might need a fix for v3.13 since I can't
entirely see why the code works as-is.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]