From: Wim Van Sebroeck <wim@iguana.be>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-watchdog@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization
Date: Sat, 15 Mar 2014 20:29:24 +0100 [thread overview]
Message-ID: <20140315192923.GA13799@spo001.leaseweb.com> (raw)
In-Reply-To: <1393925675-21636-1-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
> Initializing clk to NULL as a reset/error condition does not
> help as NULL is not an invalid condition w.r.t clk. Remove this
> initialization altogether as there is no state retention.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/watchdog/s3c2410_wdt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
> index aba6cd46b45b..a0f8f771adec 100644
> --- a/drivers/watchdog/s3c2410_wdt.c
> +++ b/drivers/watchdog/s3c2410_wdt.c
> @@ -607,7 +607,6 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
>
> err_clk:
> clk_disable_unprepare(wdt->clock);
> - wdt->clock = NULL;
>
> err:
> return ret;
> @@ -627,7 +626,6 @@ static int s3c2410wdt_remove(struct platform_device *dev)
> s3c2410wdt_cpufreq_deregister(wdt);
>
> clk_disable_unprepare(wdt->clock);
> - wdt->clock = NULL;
>
> return 0;
> }
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
prev parent reply other threads:[~2014-03-15 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 9:34 [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization Sachin Kamat
2014-03-04 9:34 ` [PATCH 2/2] watchdog: s3c2410_wdt: Check return value of clk_prepare_enable Sachin Kamat
2014-03-15 19:30 ` Wim Van Sebroeck
2014-03-10 2:32 ` [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization Guenter Roeck
2014-03-15 19:29 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140315192923.GA13799@spo001.leaseweb.com \
--to=wim@iguana.be \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox