From: Guenter Roeck <linux@roeck-us.net>
To: Sachin Kamat <sachin.kamat@linaro.org>, linux-watchdog@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization
Date: Sun, 09 Mar 2014 19:32:41 -0700 [thread overview]
Message-ID: <531D2449.4060108@roeck-us.net> (raw)
In-Reply-To: <1393925675-21636-1-git-send-email-sachin.kamat@linaro.org>
On 03/04/2014 01:34 AM, Sachin Kamat wrote:
> Initializing clk to NULL as a reset/error condition does not
> help as NULL is not an invalid condition w.r.t clk. Remove this
> initialization altogether as there is no state retention.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2014-03-10 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 9:34 [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization Sachin Kamat
2014-03-04 9:34 ` [PATCH 2/2] watchdog: s3c2410_wdt: Check return value of clk_prepare_enable Sachin Kamat
2014-03-15 19:30 ` Wim Van Sebroeck
2014-03-10 2:32 ` Guenter Roeck [this message]
2014-03-15 19:29 ` [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D2449.4060108@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox