Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Inki Dae <inki.dae@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org, jy0922.shim@samsung.com,
	tjakobi@math.uni-bielefeld.de,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer
Date: Mon, 10 Aug 2015 21:38:33 -0300	[thread overview]
Message-ID: <20150811003833.GE8125@joana> (raw)
In-Reply-To: <55C49B8A.4090009@samsung.com>

Hi Inki,

2015-08-07 Inki Dae <inki.dae@samsung.com>:

> Hi Gustavo,
> 
> On 2015년 08월 06일 22:31, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had
> > only a drm_encoder member and the internal exynos_drm_encoders ops that
> > was directly mapped to the drm_encoder helper funcs.
> > 
> > So now exynos DRM uses struct drm_encoder directly, this removes
> > completely the struct exynos_drm_encoder.
> > 
> 
> Trats2 board, which uses Exynos4412 Soc, doesn't work after this patch
> is applied. Below is the booting logs,
> [    1.171318] console [ttySAC2] enabled
> [    1.175522] 13830000.serial: ttySAC3 at MMIO 0x13830000 (irq = 60,
> base_baud = 0) is a S3C6400/10
> [    1.185545] [drm] Initialized drm 1.1.0 20060810
> [    1.194104] exynos-drm exynos-drm: bound 11c00000.fimd (ops
> fimd_component_ops)
> [    1.200352] exynos-drm exynos-drm: bound 11c80000.dsi (ops
> exynos_dsi_component_ops)
> [    1.207688] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> [    1.214313] [drm] No driver support for vblank timestamp query.
> [    1.220218] [drm] Initialized exynos 1.0.0 20110530 on minor 0
> 
> Booting is locked up here. This patch looks good to me so I tried to
> find why locked up and I found the booting is locked up as soon as
> console_lock function is called. Can you and other guys look into this
> issue?

I've realized that I left a fix for patch 01 behind, it could be the
cause of this issue. I've just resent this patch with the added v2 fix
up.

	Gustavo

  parent reply	other threads:[~2015-08-11  0:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 23:24 [PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 01/11] drm/exynos: split display's .dpms() into .enable() and .disable() Gustavo Padovan
2015-08-11  0:37   ` [PATCH " Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 02/11] drm/exynos: remove wrappers for phy_power_{on,off} Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 03/11] drm/exynos: remove unused .remove() and .check_mode() ops from display Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 04/11] drm/exynos: simplify calculation of possible CRTCs Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 05/11] drm/exynos: remove struct exynos_drm_display Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 06/11] drm/exynos: remove extra call to hdmi_commit() Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 07/11] drm/exynos: remove extra call to exynos_dp_commit() Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 08/11] drm/exynos: remove exynos_encoder's .commit() op Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 09/11] drm/exynos: remove exynos_drm_create_enc_conn() Gustavo Padovan
2015-08-06 13:31   ` [PATCH v2 10/11] drm/exynos: fold encoder setup into exynos_drm_load() Gustavo Padovan
2015-08-06 13:31     ` [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer Gustavo Padovan
2015-08-07 11:50       ` Inki Dae
2015-08-07 12:28         ` Daniel Vetter
2015-08-07 13:22           ` Inki Dae
2015-08-11  0:38         ` Gustavo Padovan [this message]
2015-08-11 12:13           ` Inki Dae
2015-08-11 15:03             ` Daniel Vetter
2015-08-12  2:53               ` Inki Dae
2015-08-12 15:49             ` Gustavo Padovan
2015-08-12 15:54               ` Gustavo Padovan
2015-08-15 14:33                 ` Inki Dae
2015-08-15 15:22                   ` Gustavo Padovan
2015-08-15 15:14       ` [PATCH -v3 " Gustavo Padovan
2015-08-06 11:55 ` [PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder Inki Dae
2015-08-06 13:27   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811003833.GE8125@joana \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox