Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

[Gustavo Padovan <gustavo@padovan.org>]

Hi Inki,

2015-08-15 Inki Dae <inki.dae@samsung.com>:

> 2015-08-13 0:54 GMT+09:00 Gustavo Padovan <gustavo@padovan.org>:
> > 2015-08-12 Gustavo Padovan <gustavo.padovan@collabora.co.uk>:
> >
> >> Hi Inki,
> >>
> >> 2015-08-11 Inki Dae <inki.dae@samsung.com>:
> >>
> >> > On 2015년 08월 11일 09:38, Gustavo Padovan wrote:
> >> > > Hi Inki,
> >> > >
> >> > > 2015-08-07 Inki Dae <inki.dae@samsung.com>:
> >> > >
> >> > >> Hi Gustavo,
> >> > >>
> >> > >> On 2015년 08월 06일 22:31, Gustavo Padovan wrote:
> >> > >>> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >> > >>>
> >> > >>> struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had
> >> > >>> only a drm_encoder member and the internal exynos_drm_encoders ops that
> >> > >>> was directly mapped to the drm_encoder helper funcs.
> >> > >>>
> >> > >>> So now exynos DRM uses struct drm_encoder directly, this removes
> >> > >>> completely the struct exynos_drm_encoder.
> >> > >>>
> >> > >>
> >> > >> Trats2 board, which uses Exynos4412 Soc, doesn't work after this patch
> >> > >> is applied. Below is the booting logs,
> >> > >> [    1.171318] console [ttySAC2] enabled
> >> > >> [    1.175522] 13830000.serial: ttySAC3 at MMIO 0x13830000 (irq = 60,
> >> > >> base_baud = 0) is a S3C6400/10
> >> > >> [    1.185545] [drm] Initialized drm 1.1.0 20060810
> >> > >> [    1.194104] exynos-drm exynos-drm: bound 11c00000.fimd (ops
> >> > >> fimd_component_ops)
> >> > >> [    1.200352] exynos-drm exynos-drm: bound 11c80000.dsi (ops
> >> > >> exynos_dsi_component_ops)
> >> > >> [    1.207688] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> >> > >> [    1.214313] [drm] No driver support for vblank timestamp query.
> >> > >> [    1.220218] [drm] Initialized exynos 1.0.0 20110530 on minor 0
> >> > >>
> >> > >> Booting is locked up here. This patch looks good to me so I tried to
> >> > >> find why locked up and I found the booting is locked up as soon as
> >> > >> console_lock function is called. Can you and other guys look into this
> >> > >> issue?
> >> > >
> >> > > I've realized that I left a fix for patch 01 behind, it could be the
> >> > > cause of this issue. I've just resent this patch with the added v2 fix
> >> > > up.
> >> >
> >> > With above change, still locked up. So your updated patch doesn't
> >> > resolve this issue.
> >> >
> >> > Anyway, I tested it with fbdev emulation relevant patch series[1] and
> >> > the booting was ok with disabling fbdev emulation as Daniel commented.
> >> > However, I think the booting should also be ok with fbdev emulation so I
> >> > don't want for your last patch to be merged to mainline until the issue
> >> > is resolved.
> >>
> >> I've tried to reproduce your issue with these patches on a odroid-x2
> >> (exynos4412) but it seems to work fine for me with fbdev emulation
> >> enabled. In snow and peach-pi it also works fine. We would need
> >> to debug better on your side to figure out what is breaking for you.
> >
> > Can you please git bisect this? So we can figure out which commit is
> > causing the issue. That would be great.
> 
> I already commented above, your last patch - 11/11. Without 11/11, it
> worked well. Did you test odroid-x2 with LVDS based Display panel? If
> so, it's not different because I tested it with Trats2 board with
> MIPI-DSI + Display panel. AFAIK, Odroid-x2 board doesn't support
> MIPI-DSI panel. I will have a pull request soon without 11/11. After
> that, I think we could find and resolve the issue later.

Ah, I thougth your talking about whole patchset! I think I figured out
what was happend the .mode_fixup() and .mode_set() helpers for the DSI
drm_encoder was not set and leading to a null pointer at some pointer.
That is problably what you were experiencing. Could you please try the
new version of patch 11/11 that I've just sent to the mailing list?
And thanks for merging these patches!

	Gustavo