* Pending rtc-s3c patches
@ 2015-10-28 10:14 Alexandre Belloni
2015-10-28 13:04 ` Krzysztof Kozlowski
2015-11-01 11:36 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Alexandre Belloni @ 2015-10-28 10:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim; +Cc: linux-samsung-soc, rtc-linux
Hi,
There are three pending patches (from 2010 and 2011) for rtc-s3c. I'd
like to get an update and either drop or apply those.
Can someone take a few minutes to review them?
The patches are:
http://patchwork.ozlabs.org/patch/71318/
http://patchwork.ozlabs.org/patch/99857/
http://patchwork.ozlabs.org/patch/101732/
I'm not sure about 71318 but I guess I can take 99857 and 101732.
Thanks,
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Pending rtc-s3c patches
2015-10-28 10:14 Pending rtc-s3c patches Alexandre Belloni
@ 2015-10-28 13:04 ` Krzysztof Kozlowski
2015-11-01 11:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-28 13:04 UTC (permalink / raw)
To: Alexandre Belloni, Kukjin Kim; +Cc: k.kozlowski.k, linux-samsung-soc, rtc-linux
W dniu 28.10.2015 o 19:14, Alexandre Belloni pisze:
> Hi,
>
> There are three pending patches (from 2010 and 2011) for rtc-s3c. I'd
> like to get an update and either drop or apply those.
>
> Can someone take a few minutes to review them?
>
> The patches are:
> http://patchwork.ozlabs.org/patch/71318/
> http://patchwork.ozlabs.org/patch/99857/
> http://patchwork.ozlabs.org/patch/101732/
>
> I'm not sure about 71318 but I guess I can take 99857 and 101732.
Hi,
I'll take a look at them in next days. Thanks for digging them out!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Pending rtc-s3c patches
2015-10-28 10:14 Pending rtc-s3c patches Alexandre Belloni
2015-10-28 13:04 ` Krzysztof Kozlowski
@ 2015-11-01 11:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2015-11-01 11:36 UTC (permalink / raw)
To: Alexandre Belloni, Kukjin Kim; +Cc: k.kozlowski.k, linux-samsung-soc, rtc-linux
W dniu 28.10.2015 o 19:14, Alexandre Belloni pisze:
> Hi,
>
> There are three pending patches (from 2010 and 2011) for rtc-s3c. I'd
> like to get an update and either drop or apply those.
>
> Can someone take a few minutes to review them?
>
> The patches are:
> http://patchwork.ozlabs.org/patch/71318/
This is not needed. The pie_lock (replacing s3c_rtc_pie_lock) protects
set_freq() which:
1. is called only during probe;
2. is accessing different registers than s3c_rtc_setaie().
> http://patchwork.ozlabs.org/patch/99857/
This is good although does not apply cleanly. I rebased, tested and send
the patch.
> http://patchwork.ozlabs.org/patch/101732/
This does not look good. Code is actually used so commit description
does not match current state. I think you can ignore it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-01 11:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-28 10:14 Pending rtc-s3c patches Alexandre Belloni
2015-10-28 13:04 ` Krzysztof Kozlowski
2015-11-01 11:36 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox