From: Gustavo Padovan <gustavo@padovan.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Inki Dae <inki.dae@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/2] drm/exynos/vidi: use timer for vblanks instead of sleeping worker
Date: Fri, 23 Sep 2016 15:27:41 +0300 [thread overview]
Message-ID: <20160923122741.GA30511@joana> (raw)
In-Reply-To: <1474618524-8916-2-git-send-email-a.hajda@samsung.com>
2016-09-23 Andrzej Hajda <a.hajda@samsung.com>:
> VIDI driver uses fake vblank handler to generate vblank events.
> It was implemented using worker which slept for vblank time, additionally
> it did not work if there were no page flips. The patch replaces it with
> timer, uses drm_crtc_vblank_(on|off) helpers to manage it and fixes
> behavior for non-page-flip cases.
> This change allows further improvements of vblank in exynos-drm framework.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_vidi.c | 66 ++++++++++----------------------
> 1 file changed, 20 insertions(+), 46 deletions(-)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
next prev parent reply other threads:[~2016-09-23 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160923081538eucas1p16f72b58a8c885c07e8188fd33dfafa8c@eucas1p1.samsung.com>
2016-09-23 8:15 ` [PATCH 0/2] Use drm-core helpers to wait for updates Andrzej Hajda
2016-09-23 8:15 ` [PATCH 1/2] drm/exynos/vidi: use timer for vblanks instead of sleeping worker Andrzej Hajda
2016-09-23 12:27 ` Gustavo Padovan [this message]
2016-09-23 8:15 ` [PATCH 2/2] drm/exynos: fix pending update handling Andrzej Hajda
2016-09-23 12:28 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923122741.GA30511@joana \
--to=gustavo@padovan.org \
--cc=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox