* [PATCH] usb: dwc3: google: Remove redundant dev_err()
@ 2026-01-15 2:38 Chen Ni
2026-01-16 17:32 ` Thinh Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2026-01-15 2:38 UTC (permalink / raw)
To: peter.griffin, andre.draszik, tudor.ambarus, Thinh.Nguyen, gregkh
Cc: linux-arm-kernel, linux-samsung-soc, linux-usb, linux-kernel,
Chen Ni
The platform_get_irq_byname() function already prints an error message
internally upon failure using dev_err_probe(). Therefore, the explicit
dev_err() is redundant and results in duplicate error logs.
Remove the redundant dev_err() call to clean up the error path.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/usb/dwc3/dwc3-google.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
index a19857bd6b13..2105c72af753 100644
--- a/drivers/usb/dwc3/dwc3-google.c
+++ b/drivers/usb/dwc3/dwc3-google.c
@@ -228,10 +228,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
int irq;
irq = platform_get_irq_byname(pdev, irq_name);
- if (irq < 0) {
- dev_err(google->dev, "invalid irq name %s\n", irq_name);
+ if (irq < 0)
return irq;
- }
irq_set_status_flags(irq, IRQ_NOAUTOEN);
ret = devm_request_threaded_irq(google->dev, irq, NULL,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: dwc3: google: Remove redundant dev_err()
2026-01-15 2:38 [PATCH] usb: dwc3: google: Remove redundant dev_err() Chen Ni
@ 2026-01-16 17:32 ` Thinh Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Thinh Nguyen @ 2026-01-16 17:32 UTC (permalink / raw)
To: Chen Ni
Cc: peter.griffin@linaro.org, andre.draszik@linaro.org,
tudor.ambarus@linaro.org, Thinh Nguyen,
gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
On Thu, Jan 15, 2026, Chen Ni wrote:
> The platform_get_irq_byname() function already prints an error message
> internally upon failure using dev_err_probe(). Therefore, the explicit
> dev_err() is redundant and results in duplicate error logs.
>
> Remove the redundant dev_err() call to clean up the error path.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/usb/dwc3/dwc3-google.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
> index a19857bd6b13..2105c72af753 100644
> --- a/drivers/usb/dwc3/dwc3-google.c
> +++ b/drivers/usb/dwc3/dwc3-google.c
> @@ -228,10 +228,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
> int irq;
>
> irq = platform_get_irq_byname(pdev, irq_name);
> - if (irq < 0) {
> - dev_err(google->dev, "invalid irq name %s\n", irq_name);
> + if (irq < 0)
> return irq;
> - }
>
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> ret = devm_request_threaded_irq(google->dev, irq, NULL,
> --
> 2.25.1
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
BR,
Thinh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-16 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 2:38 [PATCH] usb: dwc3: google: Remove redundant dev_err() Chen Ni
2026-01-16 17:32 ` Thinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox