* [PATCH] ARM: EXYNOS: Replace __ASSEMBLY__ with __ASSEMBLER__
@ 2026-08-21 8:32 Thomas Huth
2026-09-04 15:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2026-08-21 8:32 UTC (permalink / raw)
To: Krzysztof Kozlowski, Peter Griffin
Cc: Alim Akhtar, linux-arm-kernel, linux-samsung-soc, linux-kernel
While the GCC and Clang compilers already define __ASSEMBLER__ auto-
matically when compiling assembly code, __ASSEMBLY__ is a macro that
only gets defined by the Makefiles in the kernel. This can be very
confusing when switching between userspace and kernelspace coding, or
when dealing with uapi headers that rather should use __ASSEMBLER__
instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
this confusion.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Note: This has been split from an earlier bigger patch of mine into
a separate patch to ease reviewing
arch/arm/mach-exynos/smc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos/smc.h b/arch/arm/mach-exynos/smc.h
index 5c30feb8f07d9..5c7730f6259fc 100644
--- a/arch/arm/mach-exynos/smc.h
+++ b/arch/arm/mach-exynos/smc.h
@@ -32,11 +32,11 @@
#define SMC_REG_CLASS_SFR_W (0x1 << 30)
#define SMC_REG_ID_SFR_W(addr) (SMC_REG_CLASS_SFR_W | ((addr) >> 2))
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
extern void exynos_smc(u32 cmd, u32 arg1, u32 arg2, u32 arg3);
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
/* op type for SMC_CMD_SAVE and SMC_CMD_SHUTDOWN */
#define OP_TYPE_CORE 0x0
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: EXYNOS: Replace __ASSEMBLY__ with __ASSEMBLER__
2026-08-21 8:32 [PATCH] ARM: EXYNOS: Replace __ASSEMBLY__ with __ASSEMBLER__ Thomas Huth
@ 2026-09-04 15:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-04 15:29 UTC (permalink / raw)
To: Peter Griffin, Thomas Huth
Cc: Alim Akhtar, linux-arm-kernel, linux-samsung-soc, linux-kernel
On Fri, 21 Aug 2026 10:32:51 +0200, Thomas Huth wrote:
> While the GCC and Clang compilers already define __ASSEMBLER__ auto-
> matically when compiling assembly code, __ASSEMBLY__ is a macro that
> only gets defined by the Makefiles in the kernel. This can be very
> confusing when switching between userspace and kernelspace coding, or
> when dealing with uapi headers that rather should use __ASSEMBLER__
> instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
> this confusion.
>
> [...]
Applied, thanks!
[1/1] ARM: EXYNOS: Replace __ASSEMBLY__ with __ASSEMBLER__
https://git.kernel.org/krzk/linux/c/80c92d1f1a4e3000e6eb351ad8af16267b1d4e63
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-04 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 8:32 [PATCH] ARM: EXYNOS: Replace __ASSEMBLY__ with __ASSEMBLER__ Thomas Huth
2026-09-04 15:29 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox