From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanho Park <chanho61.park@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Hector Martin <marcan@marcan.st>,
Jaewon Kim <jaewon02.kim@samsung.com>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: serial: samsung_tty: support more than 4 uart ports
Date: Mon, 27 Jun 2022 12:33:51 +0200 [thread overview]
Message-ID: <2efd725f-3d99-c1df-23ce-9ee60bbe4600@linaro.org> (raw)
In-Reply-To: <20220627071512.18180-1-chanho61.park@samsung.com>
On 27/06/2022 09:15, Chanho Park wrote:
> Regarding Exynos Auto v9 SoC, it supports uarts up to 12. However, the
> maximum number of the ports has been derived from
> CONFIG_SERIAL_SAMSUNG_UARTS and tightly coupled with the config for
> previous Samsung SoCs such as s3c24xx and s3c64xx. To overcome this
> limitation, this changes the usage of the definition to UART_NR which is
> widely used from other serial drivers. This also defines the value to 12
> only for ARM64 SoCs to not affect the change to previous arm32 SoCs.
> Instead of enumerating all the ports as predefined arrays, this
> introduces s3c24xx_serial_init_port_default that is initializing the
> structure as default value.
> Regarding the ports which are greater than 4
> will be initialized as default value and the fifo size will be retrieved
> from the DT property.
You need to explain why you are doing this.
It's confusing to initialize some statically and some dynamically.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-27 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220627071726epcas2p476cfa45f74a73bfd0fcfe03eacc2df60@epcas2p4.samsung.com>
2022-06-27 7:15 ` [PATCH] tty: serial: samsung_tty: support more than 4 uart ports Chanho Park
2022-06-27 10:33 ` Krzysztof Kozlowski [this message]
2022-06-27 11:52 ` Greg Kroah-Hartman
2022-06-28 13:16 ` Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2efd725f-3d99-c1df-23ce-9ee60bbe4600@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jaewon02.kim@samsung.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox