Linux Samsung SOC development
 help / color / mirror / Atom feed
* Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
       [not found] ` <4FB048E4.8070405@linaro.org>
@ 2012-05-14  8:52   ` Heiko Stübner
  2012-05-14  8:57     ` Mark Brown
  0 siblings, 1 reply; 8+ messages in thread
From: Heiko Stübner @ 2012-05-14  8:52 UTC (permalink / raw)
  To: Daniel Lezcano, Kukjin Kim, linux-samsung-soc
  Cc: linux-arm-kernel, ben-linux, linaro-dev, patches

Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
> On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
> > These couple of patches use the new cpuidle core api to refactor
> > some part of the code. The first one declares the states directly
> > in the driver declaration and the second one use the timekeeping
> > flag to let the cpuidle core to compute the idle time.
> > 
> > I don't have this board, I was not able to test these patches.
> > 
> > Daniel Lezcano (2):
> >    ARM: s3c64xx: cpuidle - declare the states with the new api
> >    ARM: s3c64xx: cpuidle - use timekeeping wrapper
> 
> Are these patches ok for inclusion ?

you might want to include the maintainer

	Kukjin Kim <kgene.kim@samsung.com>

and the samsung list

	linux-samsung-soc@vger.kernel.org

into your recipients


Heiko

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
  2012-05-14  8:52   ` [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups Heiko Stübner
@ 2012-05-14  8:57     ` Mark Brown
  2012-05-14  9:22       ` Daniel Lezcano
  2012-05-14 13:44       ` Daniel Lezcano
  0 siblings, 2 replies; 8+ messages in thread
From: Mark Brown @ 2012-05-14  8:57 UTC (permalink / raw)
  To: Heiko St??bner
  Cc: Daniel Lezcano, Kukjin Kim, linux-samsung-soc, linux-arm-kernel,
	ben-linux, linaro-dev, patches

On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
> Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
> > On 05/09/2012 04:08 PM, Daniel Lezcano wrote:

> > Are these patches ok for inclusion ?

> you might want to include the maintainer

> 	Kukjin Kim <kgene.kim@samsung.com>

> and the samsung list

> 	linux-samsung-soc@vger.kernel.org

> into your recipients

Also the original author (me).

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
  2012-05-14  8:57     ` Mark Brown
@ 2012-05-14  9:22       ` Daniel Lezcano
  2012-05-14 13:51         ` Kukjin Kim
  2012-05-14 13:44       ` Daniel Lezcano
  1 sibling, 1 reply; 8+ messages in thread
From: Daniel Lezcano @ 2012-05-14  9:22 UTC (permalink / raw)
  To: Mark Brown
  Cc: Heiko St??bner, Kukjin Kim, linux-samsung-soc, linux-arm-kernel,
	ben-linux, linaro-dev, patches

On 05/14/2012 10:57 AM, Mark Brown wrote:
> On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
>> Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
>>> On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
>
>>> Are these patches ok for inclusion ?
>
>> you might want to include the maintainer
>
>> 	Kukjin Kim<kgene.kim@samsung.com>
>
>> and the samsung list
>
>> 	linux-samsung-soc@vger.kernel.org
>
>> into your recipients
>
> Also the original author (me).

Oh, ok. I thought I did it, sorry.

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
  2012-05-14  8:57     ` Mark Brown
  2012-05-14  9:22       ` Daniel Lezcano
@ 2012-05-14 13:44       ` Daniel Lezcano
  1 sibling, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2012-05-14 13:44 UTC (permalink / raw)
  To: Mark Brown
  Cc: Heiko St??bner, Kukjin Kim, linaro-dev, patches,
	linux-samsung-soc, ben-linux, linux-arm-kernel

On 05/14/2012 10:57 AM, Mark Brown wrote:
> On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
>> Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
>>> On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
>>> Are these patches ok for inclusion ?
>> you might want to include the maintainer
>> 	Kukjin Kim<kgene.kim@samsung.com>
>> and the samsung list
>> 	linux-samsung-soc@vger.kernel.org
>> into your recipients
> Also the original author (me).

Mark,

I noticed you are not in the cpuidle.c header file neither in the 
MAINTAINERS entry for the s3c64xx.
Just FYI.

Thanks
-- Daniel


-- 
  <http://www.linaro.org/>  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:<http://www.facebook.com/pages/Linaro>  Facebook |
<http://twitter.com/#!/linaroorg>  Twitter |
<http://www.linaro.org/linaro-blog/>  Blog

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
  2012-05-14  9:22       ` Daniel Lezcano
@ 2012-05-14 13:51         ` Kukjin Kim
  2012-05-14 13:56           ` Daniel Lezcano
  0 siblings, 1 reply; 8+ messages in thread
From: Kukjin Kim @ 2012-05-14 13:51 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Mark Brown, Heiko St??bner, Kukjin Kim, linux-samsung-soc,
	linux-arm-kernel, ben-linux, linaro-dev, patches

On 05/14/12 18:22, Daniel Lezcano wrote:
> On 05/14/2012 10:57 AM, Mark Brown wrote:
>> On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
>>> Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
>>>> On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
>>
>>>> Are these patches ok for inclusion ?
>>
>>> you might want to include the maintainer
>>
>>> Kukjin Kim<kgene.kim@samsung.com>
>>
>>> and the samsung list
>>
>>> linux-samsung-soc@vger.kernel.org
>>
>>> into your recipients
>>
>> Also the original author (me).
>
> Oh, ok. I thought I did it, sorry.
>
Heiko, thanks :-)

Daniel, could you please re-submit this series with adding me and Mark 
Brown in Cc. I couldn't find your patches in my mailbox...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
  2012-05-14 13:51         ` Kukjin Kim
@ 2012-05-14 13:56           ` Daniel Lezcano
  0 siblings, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2012-05-14 13:56 UTC (permalink / raw)
  To: Kukjin Kim
  Cc: Mark Brown, Heiko St??bner, linux-samsung-soc, linux-arm-kernel,
	ben-linux, linaro-dev, patches

On 05/14/2012 03:51 PM, Kukjin Kim wrote:
> On 05/14/12 18:22, Daniel Lezcano wrote:
>> On 05/14/2012 10:57 AM, Mark Brown wrote:
>>> On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
>>>> Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
>>>>> On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
>>>
>>>>> Are these patches ok for inclusion ?
>>>
>>>> you might want to include the maintainer
>>>
>>>> Kukjin Kim<kgene.kim@samsung.com>
>>>
>>>> and the samsung list
>>>
>>>> linux-samsung-soc@vger.kernel.org
>>>
>>>> into your recipients
>>>
>>> Also the original author (me).
>>
>> Oh, ok. I thought I did it, sorry.
>>
> Heiko, thanks :-)
>
> Daniel, could you please re-submit this series with adding me and Mark
> Brown in Cc. I couldn't find your patches in my mailbox...

Sure.

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
@ 2012-05-14 14:06 Daniel Lezcano
  2012-05-17  6:57 ` Kukjin Kim
  0 siblings, 1 reply; 8+ messages in thread
From: Daniel Lezcano @ 2012-05-14 14:06 UTC (permalink / raw)
  To: ben-linux, kgene.kim, broonie
  Cc: linux-arm-kernel, linaro-dev, patches, linux-samsung-soc, heiko

These couple of patches use the new cpuidle core api to refactor
some part of the code. The first one declares the states directly
in the driver declaration and the second one use the timekeeping
flag to let the cpuidle core to compute the idle time.

I don't have this board, I was not able to test these patches.

Daniel Lezcano (2):
  ARM: s3c64xx: cpuidle - declare the states with the new api
  ARM: s3c64xx: cpuidle - use timekeeping wrapper

 arch/arm/mach-s3c64xx/cpuidle.c |   45 +++++++++++++--------------------------
 1 files changed, 15 insertions(+), 30 deletions(-)

-- 
1.7.5.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
  2012-05-14 14:06 Daniel Lezcano
@ 2012-05-17  6:57 ` Kukjin Kim
  0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2012-05-17  6:57 UTC (permalink / raw)
  To: 'Daniel Lezcano', ben-linux, broonie
  Cc: linux-arm-kernel, linaro-dev, patches, linux-samsung-soc, heiko

Daniel Lezcano wrote:
> 
> These couple of patches use the new cpuidle core api to refactor
> some part of the code. The first one declares the states directly
> in the driver declaration and the second one use the timekeeping
> flag to let the cpuidle core to compute the idle time.
> 
Basically, looks ok to me.

> I don't have this board, I was not able to test these patches.
> 
Mark, could you please check this patches on your board?
Now, my smdk6410 has some problem to test this :(

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> Daniel Lezcano (2):
>   ARM: s3c64xx: cpuidle - declare the states with the new api
>   ARM: s3c64xx: cpuidle - use timekeeping wrapper
> 
>  arch/arm/mach-s3c64xx/cpuidle.c |   45
+++++++++++++----------------------
> ----
>  1 files changed, 15 insertions(+), 30 deletions(-)
> 
> --
> 1.7.5.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-05-17  6:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1336572489-21457-1-git-send-email-daniel.lezcano@linaro.org>
     [not found] ` <4FB048E4.8070405@linaro.org>
2012-05-14  8:52   ` [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups Heiko Stübner
2012-05-14  8:57     ` Mark Brown
2012-05-14  9:22       ` Daniel Lezcano
2012-05-14 13:51         ` Kukjin Kim
2012-05-14 13:56           ` Daniel Lezcano
2012-05-14 13:44       ` Daniel Lezcano
2012-05-14 14:06 Daniel Lezcano
2012-05-17  6:57 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox