Re: [PATCH 1/1] ARM: EXYNOS: Consolidate Kconfig entries

[Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>]

Hi,

On Thursday, February 06, 2014 03:10:39 PM Tomasz Figa wrote:
> Hi Sachin,
> 
> On 06.02.2014 12:59, Sachin Kamat wrote:
> > Instead of repeating the Kconfig entries for every SoC, move them under
> > ARCH_EXYNOS4 and 5 and move the entries common to both 4 and 5 under
> > ARCH_EXYNOS. Also, since the individual SoCs do not have any specific
> > machine/platform code, keep them as boolean symbols instead of user

All soc_is_exynosxxxx() dependent code gets thrown away is specific SoC
support is not selected.  With this change this is not longer true.
Moreover some drivers are doing explicit ifdef checks for specific SoC
support, i.e. thermal driver.

> > selectable and select them from Exynos4 and 5 config symbols. Individual
> > SoC symbols can be removed eventually once the driver Kconfig dependencies
> > on these symbols are removed.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> >   arch/arm/Kconfig             |   12 ++++++
> >   arch/arm/mach-exynos/Kconfig |   97 ++++++++++--------------------------------
> >   2 files changed, 35 insertions(+), 74 deletions(-)
> 
> I fully agree that there is no real need of having per-SoC Kconfig 
> entries, since the differences caused by them are quite insignificant. 

I think so but some numbers to back it up would be good..

> Moreover, this makes me wonder if there is even need to distinguish 
> between ARCH_EXYNOS4 and ARCH_EXYNOS5...

Well, once again, seeing some numbers would be good. :)

> Anyway, I second this patch:
> 
> Acked-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics