From: Tushar Behera <tushar.behera@linaro.org>
To: Kukjin Kim <kgene.kim@samsung.com>, linux-samsung-soc@vger.kernel.org
Cc: 'Sachin Kamat' <sachin.kamat@linaro.org>
Subject: Re: [PATCH 1/1] ARM: exynos_defconfig: Enable HS-I2C
Date: Mon, 28 Apr 2014 09:26:18 +0530 [thread overview]
Message-ID: <535DD162.1080404@linaro.org> (raw)
In-Reply-To: <0b5b01cf6140$afd3d390$0f7b7ab0$@samsung.com>
On 04/26/2014 04:44 PM, Kukjin Kim wrote:
> Tushar Behera wrote:
>>
>> On 03/04/2014 05:52 PM, Sachin Kamat wrote:
>>> High speed I2C is used on Exynos5 based SoCs. Enable it.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>> arch/arm/configs/exynos_defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/configs/exynos_defconfig
>> b/arch/arm/configs/exynos_defconfig
>>> index 4ce7b70ea901..e07a227ec0db 100644
>>> --- a/arch/arm/configs/exynos_defconfig
>>> +++ b/arch/arm/configs/exynos_defconfig
>>> @@ -65,6 +65,7 @@ CONFIG_TCG_TIS_I2C_INFINEON=y
>>> CONFIG_I2C=y
>>> CONFIG_I2C_MUX=y
>>> CONFIG_I2C_ARB_GPIO_CHALLENGE=y
>>> +CONFIG_I2C_EXYNOS5=y
>>> CONFIG_I2C_S3C2410=y
>>> CONFIG_DEBUG_GPIO=y
>>> # CONFIG_HWMON is not set
>>>
>> Kukjin,
>>
>> Please consider picking this patch when you plan to update
>> exynos_defconfig. With this change on upstream kernel, we are able to
>> get Arndale_Octa board to boot and mount an MMC partition successfully.
>>
> Oh, OK.
>
> BTW, basically the boot should be fine with/without selecting
The boot is just fine. Just that, we can't use the MMC partition to
mount rootfs.
> I2C_EXYNOS5...or if the config is required always for arndale_octa board, it
> should be enabled without any manual selecting. I think, it means this is
> just temporal solution not right approach to fix the problem..
>
I don't see any reason why HS-I2C support not be enabled by default on
exynos_defconfig. On many boards,the regulators are connected HS-I2C bus
and without this option enabled the regulators don't come by default.
If you have any reason why this is not the right approach to fix the
problem, please let us know.
> I need to look at the codes...
>
> Thanks,
> Kukjin
>
--
Tushar Behera
prev parent reply other threads:[~2014-04-28 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 12:22 [PATCH 1/1] ARM: exynos_defconfig: Enable HS-I2C Sachin Kamat
2014-04-24 8:02 ` Tushar Behera
2014-04-26 11:14 ` Kukjin Kim
2014-04-28 3:56 ` Tushar Behera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535DD162.1080404@linaro.org \
--to=tushar.behera@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox