[PATCH 1/1] ARM: exynos_defconfig: Enable HS-I2C

[PATCH 1/1] ARM: exynos_defconfig: Enable HS-I2C

[Sachin Kamat]

High speed I2C is used on Exynos5 based SoCs. Enable it.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/configs/exynos_defconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 4ce7b70ea901..e07a227ec0db 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -65,6 +65,7 @@ CONFIG_TCG_TIS_I2C_INFINEON=y
 CONFIG_I2C=y
 CONFIG_I2C_MUX=y
 CONFIG_I2C_ARB_GPIO_CHALLENGE=y
+CONFIG_I2C_EXYNOS5=y
 CONFIG_I2C_S3C2410=y
 CONFIG_DEBUG_GPIO=y
 # CONFIG_HWMON is not set
-- 
1.7.9.5

Re: [PATCH 1/1] ARM: exynos_defconfig: Enable HS-I2C

[Tushar Behera]

On 03/04/2014 05:52 PM, Sachin Kamat wrote:
> High speed I2C is used on Exynos5 based SoCs. Enable it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/configs/exynos_defconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 4ce7b70ea901..e07a227ec0db 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -65,6 +65,7 @@ CONFIG_TCG_TIS_I2C_INFINEON=y
>  CONFIG_I2C=y
>  CONFIG_I2C_MUX=y
>  CONFIG_I2C_ARB_GPIO_CHALLENGE=y
> +CONFIG_I2C_EXYNOS5=y
>  CONFIG_I2C_S3C2410=y
>  CONFIG_DEBUG_GPIO=y
>  # CONFIG_HWMON is not set
> 
Kukjin,

Please consider picking this patch when you plan to update
exynos_defconfig. With this change on upstream kernel, we are able to
get Arndale_Octa board to boot and mount an MMC partition successfully.

-- 
Tushar Behera

RE: [PATCH 1/1] ARM: exynos_defconfig: Enable HS-I2C

[Kukjin Kim]

Tushar Behera wrote:
> 
> On 03/04/2014 05:52 PM, Sachin Kamat wrote:
> > High speed I2C is used on Exynos5 based SoCs. Enable it.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> >  arch/arm/configs/exynos_defconfig |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/exynos_defconfig
> b/arch/arm/configs/exynos_defconfig
> > index 4ce7b70ea901..e07a227ec0db 100644
> > --- a/arch/arm/configs/exynos_defconfig
> > +++ b/arch/arm/configs/exynos_defconfig
> > @@ -65,6 +65,7 @@ CONFIG_TCG_TIS_I2C_INFINEON=y
> >  CONFIG_I2C=y
> >  CONFIG_I2C_MUX=y
> >  CONFIG_I2C_ARB_GPIO_CHALLENGE=y
> > +CONFIG_I2C_EXYNOS5=y
> >  CONFIG_I2C_S3C2410=y
> >  CONFIG_DEBUG_GPIO=y
> >  # CONFIG_HWMON is not set
> >
> Kukjin,
> 
> Please consider picking this patch when you plan to update
> exynos_defconfig. With this change on upstream kernel, we are able to
> get Arndale_Octa board to boot and mount an MMC partition successfully.
> 
Oh, OK.

BTW, basically the boot should be fine with/without selecting
I2C_EXYNOS5...or if the config is required always for arndale_octa board, it
should be enabled without any manual selecting. I think, it means this is
just temporal solution not right approach to fix the problem..

I need to look at the codes...

Thanks,
Kukjin

Re: [PATCH 1/1] ARM: exynos_defconfig: Enable HS-I2C

[Tushar Behera]

On 04/26/2014 04:44 PM, Kukjin Kim wrote:
> Tushar Behera wrote:
>>
>> On 03/04/2014 05:52 PM, Sachin Kamat wrote:
>>> High speed I2C is used on Exynos5 based SoCs. Enable it.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>>  arch/arm/configs/exynos_defconfig |    1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/configs/exynos_defconfig
>> b/arch/arm/configs/exynos_defconfig
>>> index 4ce7b70ea901..e07a227ec0db 100644
>>> --- a/arch/arm/configs/exynos_defconfig
>>> +++ b/arch/arm/configs/exynos_defconfig
>>> @@ -65,6 +65,7 @@ CONFIG_TCG_TIS_I2C_INFINEON=y
>>>  CONFIG_I2C=y
>>>  CONFIG_I2C_MUX=y
>>>  CONFIG_I2C_ARB_GPIO_CHALLENGE=y
>>> +CONFIG_I2C_EXYNOS5=y
>>>  CONFIG_I2C_S3C2410=y
>>>  CONFIG_DEBUG_GPIO=y
>>>  # CONFIG_HWMON is not set
>>>
>> Kukjin,
>>
>> Please consider picking this patch when you plan to update
>> exynos_defconfig. With this change on upstream kernel, we are able to
>> get Arndale_Octa board to boot and mount an MMC partition successfully.
>>
> Oh, OK.
> 
> BTW, basically the boot should be fine with/without selecting

The boot is just fine. Just that, we can't use the MMC partition to
mount rootfs.

> I2C_EXYNOS5...or if the config is required always for arndale_octa board, it
> should be enabled without any manual selecting. I think, it means this is
> just temporal solution not right approach to fix the problem..
> 

I don't see any reason why HS-I2C support not be enabled by default on
exynos_defconfig. On many boards,the regulators are connected HS-I2C bus
and without this option enabled the regulators don't come by default.

If you have any reason why this is not the right approach to fix the
problem, please let us know.

> I need to look at the codes...
> 
> Thanks,
> Kukjin
> 

-- 
Tushar Behera