* [PATCH 4/5] devfreq: exynos4: Use devm_devfreq_* function using device resource management
[not found] <1398416894-6782-1-git-send-email-cw00.choi@samsung.com>
@ 2014-04-25 9:08 ` Chanwoo Choi
2014-04-25 9:08 ` [PATCH 5/5] devfreq: exynos5: " Chanwoo Choi
1 sibling, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2014-04-25 9:08 UTC (permalink / raw)
To: myungjoo.ham, kyungmin.park
Cc: rafael.j.wysocki, nm, cw00.choi, jkosina, labbe.montjoie,
linux-pm, linux-kernel, Kukjin Kim, Bartlomiej Zolnierkiewicz,
Wei Yongjun, linux-arm-kernel, linux-samsung-soc
This patch uses devm_devfreq_add_device()/devm_devfreq_register_opp_notifier()
to control automatically the resource of devfreq.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
---
drivers/devfreq/exynos/exynos4_bus.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/devfreq/exynos/exynos4_bus.c b/drivers/devfreq/exynos/exynos4_bus.c
index d257f1f..bebb0a4 100644
--- a/drivers/devfreq/exynos/exynos4_bus.c
+++ b/drivers/devfreq/exynos/exynos4_bus.c
@@ -979,7 +979,7 @@ static int exynos4_busfreq_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, data);
- data->devfreq = devfreq_add_device(dev, &exynos4_devfreq_profile,
+ data->devfreq = devm_devfreq_add_device(dev, &exynos4_devfreq_profile,
"simple_ondemand", NULL);
if (IS_ERR(data->devfreq))
return PTR_ERR(data->devfreq);
@@ -991,27 +991,20 @@ static int exynos4_busfreq_probe(struct platform_device *pdev)
busfreq_mon_reset(ppmu_data);
/* Register opp_notifier for Exynos4 busfreq */
- err = devfreq_register_opp_notifier(dev, data->devfreq);
+ err = devm_devfreq_register_opp_notifier(dev, data->devfreq);
if (err < 0) {
dev_err(dev, "Failed to register opp notifier\n");
- goto err_notifier_opp;
+ return err;
}
/* Register pm_notifier for Exynos4 busfreq */
err = register_pm_notifier(&data->pm_notifier);
if (err) {
dev_err(dev, "Failed to setup pm notifier\n");
- goto err_notifier_pm;
+ return err;
}
return 0;
-
-err_notifier_pm:
- devfreq_unregister_opp_notifier(dev, data->devfreq);
-err_notifier_opp:
- devfreq_remove_device(data->devfreq);
-
- return err;
}
static int exynos4_busfreq_remove(struct platform_device *pdev)
@@ -1020,10 +1013,6 @@ static int exynos4_busfreq_remove(struct platform_device *pdev)
/* Unregister all of notifier chain */
unregister_pm_notifier(&data->pm_notifier);
- devfreq_unregister_opp_notifier(data->dev, data->devfreq);
-
- /* Remove devfreq instance */
- devfreq_remove_device(data->devfreq);
return 0;
}
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 5/5] devfreq: exynos5: Use devm_devfreq_* function using device resource management
[not found] <1398416894-6782-1-git-send-email-cw00.choi@samsung.com>
2014-04-25 9:08 ` [PATCH 4/5] devfreq: exynos4: Use devm_devfreq_* function using device resource management Chanwoo Choi
@ 2014-04-25 9:08 ` Chanwoo Choi
2014-04-29 16:54 ` Sachin Kamat
1 sibling, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2014-04-25 9:08 UTC (permalink / raw)
To: myungjoo.ham, kyungmin.park
Cc: rafael.j.wysocki, nm, cw00.choi, jkosina, labbe.montjoie,
linux-pm, linux-kernel, Kukjin Kim, Sachin Kamat,
Bartlomiej Zolnierkiewicz, Manish Badarkhe, Abhilash Kesavan,
linux-arm-kernel, linux-samsung-soc
This patch uses devm_devfreq_add_device()/devm_devfreq_register_opp_notifier()
to control automatically the resource of devfreq.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Manish Badarkhe <badarkhe.manish@gmail.com>
Cc: Abhilash Kesavan <a.kesavan@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
---
drivers/devfreq/exynos/exynos5_bus.c | 23 ++++++++---------------
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/devfreq/exynos/exynos5_bus.c b/drivers/devfreq/exynos/exynos5_bus.c
index ab54a69..1f622f8 100644
--- a/drivers/devfreq/exynos/exynos5_bus.c
+++ b/drivers/devfreq/exynos/exynos5_bus.c
@@ -165,11 +165,6 @@ static int exynos5_int_get_dev_status(struct device *dev,
}
static void exynos5_int_exit(struct device *dev)
{
- struct platform_device *pdev = container_of(dev, struct platform_device,
- dev);
- struct busfreq_data_int *data = platform_get_drvdata(pdev);
-
- devfreq_unregister_opp_notifier(dev, data->devfreq);
}
static struct devfreq_dev_profile exynos5_devfreq_int_profile = {
@@ -343,30 +338,29 @@ static int exynos5_busfreq_int_probe(struct platform_device *pdev)
busfreq_mon_reset(ppmu_data);
- data->devfreq = devfreq_add_device(dev, &exynos5_devfreq_int_profile,
+ data->devfreq = devm_devfreq_add_device(dev, &exynos5_devfreq_int_profile,
"simple_ondemand", NULL);
-
if (IS_ERR(data->devfreq)) {
err = PTR_ERR(data->devfreq);
- goto err_devfreq_add;
+ return err;
}
- devfreq_register_opp_notifier(dev, data->devfreq);
+ err = devm_devfreq_register_opp_notifier(dev, data->devfreq);
+ if (err < 0) {
+ dev_err(dev, "Failed to register opp notifier\n");
+ return err;
+ }
err = register_pm_notifier(&data->pm_notifier);
if (err) {
dev_err(dev, "Failed to setup pm notifier\n");
- goto err_devfreq_add;
+ return err;
}
/* TODO: Add a new QOS class for int/mif bus */
pm_qos_add_request(&data->int_req, PM_QOS_NETWORK_THROUGHPUT, -1);
return 0;
-
-err_devfreq_add:
- devfreq_remove_device(data->devfreq);
- return err;
}
static int exynos5_busfreq_int_remove(struct platform_device *pdev)
@@ -375,7 +369,6 @@ static int exynos5_busfreq_int_remove(struct platform_device *pdev)
pm_qos_remove_request(&data->int_req);
unregister_pm_notifier(&data->pm_notifier);
- devfreq_remove_device(data->devfreq);
return 0;
}
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 5/5] devfreq: exynos5: Use devm_devfreq_* function using device resource management
2014-04-25 9:08 ` [PATCH 5/5] devfreq: exynos5: " Chanwoo Choi
@ 2014-04-29 16:54 ` Sachin Kamat
2014-04-30 0:58 ` Chanwoo Choi
0 siblings, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2014-04-29 16:54 UTC (permalink / raw)
To: Chanwoo Choi
Cc: MyungJoo Ham, Kyungmin Park, rafael.j.wysocki, Nishanth Menon,
Jiri Kosina, labbe.montjoie, linux-pm@vger.kernel.org, LKML,
Kukjin Kim, Bartlomiej Zolnierkiewicz, Manish Badarkhe,
Abhilash Kesavan, linux-arm-kernel, linux-samsung-soc
Hi Chanwoo,
On 25 April 2014 14:38, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch uses devm_devfreq_add_device()/devm_devfreq_register_opp_notifier()
> to control automatically the resource of devfreq.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Manish Badarkhe <badarkhe.manish@gmail.com>
> Cc: Abhilash Kesavan <a.kesavan@samsung.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> ---
> drivers/devfreq/exynos/exynos5_bus.c | 23 ++++++++---------------
> 1 file changed, 8 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/devfreq/exynos/exynos5_bus.c b/drivers/devfreq/exynos/exynos5_bus.c
> index ab54a69..1f622f8 100644
> --- a/drivers/devfreq/exynos/exynos5_bus.c
> +++ b/drivers/devfreq/exynos/exynos5_bus.c
> @@ -165,11 +165,6 @@ static int exynos5_int_get_dev_status(struct device *dev,
> }
> static void exynos5_int_exit(struct device *dev)
> {
> - struct platform_device *pdev = container_of(dev, struct platform_device,
> - dev);
> - struct busfreq_data_int *data = platform_get_drvdata(pdev);
> -
> - devfreq_unregister_opp_notifier(dev, data->devfreq);
> }
Do you need an empty function?
>
> static struct devfreq_dev_profile exynos5_devfreq_int_profile = {
> @@ -343,30 +338,29 @@ static int exynos5_busfreq_int_probe(struct platform_device *pdev)
>
> busfreq_mon_reset(ppmu_data);
>
> - data->devfreq = devfreq_add_device(dev, &exynos5_devfreq_int_profile,
> + data->devfreq = devm_devfreq_add_device(dev, &exynos5_devfreq_int_profile,
> "simple_ondemand", NULL);
> -
> if (IS_ERR(data->devfreq)) {
> err = PTR_ERR(data->devfreq);
No need of err. return PTR_ERR(data->devfreq);
> - goto err_devfreq_add;
> + return err;
> }
>
> - devfreq_register_opp_notifier(dev, data->devfreq);
> + err = devm_devfreq_register_opp_notifier(dev, data->devfreq);
> + if (err < 0) {
> + dev_err(dev, "Failed to register opp notifier\n");
> + return err;
> + }
>
> err = register_pm_notifier(&data->pm_notifier);
> if (err) {
> dev_err(dev, "Failed to setup pm notifier\n");
> - goto err_devfreq_add;
> + return err;
> }
>
> /* TODO: Add a new QOS class for int/mif bus */
> pm_qos_add_request(&data->int_req, PM_QOS_NETWORK_THROUGHPUT, -1);
>
> return 0;
> -
> -err_devfreq_add:
> - devfreq_remove_device(data->devfreq);
> - return err;
> }
>
> static int exynos5_busfreq_int_remove(struct platform_device *pdev)
> @@ -375,7 +369,6 @@ static int exynos5_busfreq_int_remove(struct platform_device *pdev)
>
> pm_qos_remove_request(&data->int_req);
> unregister_pm_notifier(&data->pm_notifier);
> - devfreq_remove_device(data->devfreq);
>
> return 0;
> }
> --
> 1.8.0
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 5/5] devfreq: exynos5: Use devm_devfreq_* function using device resource management
2014-04-29 16:54 ` Sachin Kamat
@ 2014-04-30 0:58 ` Chanwoo Choi
0 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2014-04-30 0:58 UTC (permalink / raw)
To: Sachin Kamat
Cc: MyungJoo Ham, Kyungmin Park, rafael.j.wysocki, Nishanth Menon,
Jiri Kosina, labbe.montjoie, linux-pm@vger.kernel.org, LKML,
Kukjin Kim, Bartlomiej Zolnierkiewicz, Manish Badarkhe,
Abhilash Kesavan, linux-arm-kernel, linux-samsung-soc
Hi Sachin,
On 04/30/2014 01:54 AM, Sachin Kamat wrote:
> Hi Chanwoo,
>
> On 25 April 2014 14:38, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> This patch uses devm_devfreq_add_device()/devm_devfreq_register_opp_notifier()
>> to control automatically the resource of devfreq.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Cc: Kukjin Kim <kgene.kim@samsung.com>
>> Cc: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>> Cc: Manish Badarkhe <badarkhe.manish@gmail.com>
>> Cc: Abhilash Kesavan <a.kesavan@samsung.com>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-samsung-soc@vger.kernel.org
>> ---
>> drivers/devfreq/exynos/exynos5_bus.c | 23 ++++++++---------------
>> 1 file changed, 8 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/devfreq/exynos/exynos5_bus.c b/drivers/devfreq/exynos/exynos5_bus.c
>> index ab54a69..1f622f8 100644
>> --- a/drivers/devfreq/exynos/exynos5_bus.c
>> +++ b/drivers/devfreq/exynos/exynos5_bus.c
>> @@ -165,11 +165,6 @@ static int exynos5_int_get_dev_status(struct device *dev,
>> }
>> static void exynos5_int_exit(struct device *dev)
>> {
>> - struct platform_device *pdev = container_of(dev, struct platform_device,
>> - dev);
>> - struct busfreq_data_int *data = platform_get_drvdata(pdev);
>> -
>> - devfreq_unregister_opp_notifier(dev, data->devfreq);
>> }
>
> Do you need an empty function?
exynos5_init_exit() function would be removed because this function is not necessary.
>
>>
>> static struct devfreq_dev_profile exynos5_devfreq_int_profile = {
>> @@ -343,30 +338,29 @@ static int exynos5_busfreq_int_probe(struct platform_device *pdev)
>>
>> busfreq_mon_reset(ppmu_data);
>>
>> - data->devfreq = devfreq_add_device(dev, &exynos5_devfreq_int_profile,
>> + data->devfreq = devm_devfreq_add_device(dev, &exynos5_devfreq_int_profile,
>> "simple_ondemand", NULL);
>> -
>> if (IS_ERR(data->devfreq)) {
>> err = PTR_ERR(data->devfreq);
>
> No need of err. return PTR_ERR(data->devfreq);
OK, I'll fix it.
>
>> - goto err_devfreq_add;
>> + return err;
>> }
>>
>> - devfreq_register_opp_notifier(dev, data->devfreq);
>> + err = devm_devfreq_register_opp_notifier(dev, data->devfreq);
>> + if (err < 0) {
>> + dev_err(dev, "Failed to register opp notifier\n");
>> + return err;
>> + }
>>
>> err = register_pm_notifier(&data->pm_notifier);
>> if (err) {
>> dev_err(dev, "Failed to setup pm notifier\n");
>> - goto err_devfreq_add;
>> + return err;
>> }
>>
>> /* TODO: Add a new QOS class for int/mif bus */
>> pm_qos_add_request(&data->int_req, PM_QOS_NETWORK_THROUGHPUT, -1);
>>
>> return 0;
>> -
>> -err_devfreq_add:
>> - devfreq_remove_device(data->devfreq);
>> - return err;
>> }
>>
>> static int exynos5_busfreq_int_remove(struct platform_device *pdev)
>> @@ -375,7 +369,6 @@ static int exynos5_busfreq_int_remove(struct platform_device *pdev)
>>
>> pm_qos_remove_request(&data->int_req);
>> unregister_pm_notifier(&data->pm_notifier);
>> - devfreq_remove_device(data->devfreq);
>>
>> return 0;
>> }
>> --
>> 1.8.0
>>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-30 0:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1398416894-6782-1-git-send-email-cw00.choi@samsung.com>
2014-04-25 9:08 ` [PATCH 4/5] devfreq: exynos4: Use devm_devfreq_* function using device resource management Chanwoo Choi
2014-04-25 9:08 ` [PATCH 5/5] devfreq: exynos5: " Chanwoo Choi
2014-04-29 16:54 ` Sachin Kamat
2014-04-30 0:58 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox