* [RESEND] [PATCH 1/1] ARM: dts: Add LEDs on odroid XU3 board
@ 2015-04-13 8:43 Markus Reichl
0 siblings, 0 replies; 6+ messages in thread
From: Markus Reichl @ 2015-04-13 8:43 UTC (permalink / raw)
To: linux-samsung-soc, Kukjin Kim, Anand Moon
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King
This patch adds the RGB-LED on XU3 as 3 gpio-leds.
It is derived from hardkernel's 3.10 tree.
Tested-by: Anand Moon <linux.amoon@gmail.com>
Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index a519c86..0a32302 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -278,6 +278,30 @@
rtc@101E0000 {
status = "okay";
};
+
+ leds {
+ compatible = "gpio-leds";
+ heartbeat {
+ label = "blue:heartbeart";
+ gpios = <&gpb2 2 0>;
+ default-state = "off";
+ linux,default-trigger = "heartbeat";
+ };
+
+ eMMC {
+ label = "green:eMMC";
+ gpios = <&gpb2 1 0>;
+ default-state = "off";
+ linux,default-trigger = "mmc0";
+ };
+
+ microSD {
+ label = "red:microSD";
+ gpios = <&gpx2 3 0>;
+ default-state = "off";
+ linux,default-trigger = "mmc1";
+ };
+ };
};
&hdmi {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RESEND] [PATCH 1/1] ARM: dts: Add LEDs on odroid XU3 board
@ 2015-05-08 7:34 Markus Reichl
2015-05-08 7:52 ` Krzysztof Kozlowski
2015-05-08 18:59 ` Kukjin Kim
0 siblings, 2 replies; 6+ messages in thread
From: Markus Reichl @ 2015-05-08 7:34 UTC (permalink / raw)
To: linux-samsung-soc, Kukjin Kim, Krzysztof Kozlowski; +Cc: Anand Moon
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
This patch adds the RGB-LED on XU3 as 3 gpio-leds.
Tested-by: Anand Moon <linux.amoon@gmail.com>
Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
---
It is derived from hardkernel's 3.10 tree.
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index a519c86..0a32302 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -278,6 +278,30 @@
rtc@101E0000 {
status = "okay";
};
+
+ leds {
+ compatible = "gpio-leds";
+ heartbeat {
+ label = "blue:heartbeart";
+ gpios = <&gpb2 2 0>;
+ default-state = "off";
+ linux,default-trigger = "heartbeat";
+ };
+
+ eMMC {
+ label = "green:eMMC";
+ gpios = <&gpb2 1 0>;
+ default-state = "off";
+ linux,default-trigger = "mmc0";
+ };
+
+ microSD {
+ label = "red:microSD";
+ gpios = <&gpx2 3 0>;
+ default-state = "off";
+ linux,default-trigger = "mmc1";
+ };
+ };
};
&hdmi {
--
1.9.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RESEND] [PATCH 1/1] ARM: dts: Add LEDs on odroid XU3 board
2015-05-08 7:34 Markus Reichl
@ 2015-05-08 7:52 ` Krzysztof Kozlowski
2015-05-08 9:10 ` Markus Reichl
2015-05-08 18:59 ` Kukjin Kim
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-08 7:52 UTC (permalink / raw)
To: m.reichl, linux-samsung-soc, Kukjin Kim; +Cc: Anand Moon
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08.05.2015 16:34, Markus Reichl wrote:
> This patch adds the RGB-LED on XU3 as 3 gpio-leds.
>
> Tested-by: Anand Moon <linux.amoon@gmail.com>
Unfortunately I could not found on LKML email from Anand that he
tested it. You sent the patch first time on 2nd of April - without
Anand's tested-by. On 13th of April it appeared with his tag.
Guys, even when you work closely please send all tags publicly on LKML
so everyone could see them.
Anand, do you confirm the tested-by?
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> --- It is
> derived from hardkernel's 3.10 tree.
Hmmm... Whose original code it was? Shouldn't there be someone else
Signed-off-by here?
Best regards,
Krzysztof
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJVTGsoAAoJEME3ZuaGi4PXbPAP/jDFtVian19v6L1MsnPYGJtk
xD+V+JhpgcDWRaxTIBlS3xdcrTO1Ci/+C/b1Me7a1amczvNPEL2iT53d0rSDX+QA
UufqWylu0n/QScthCOn3en0ghGibCoAT2d5hIyeAMPPka66xBrIgkp7ZffOQfpnR
+rNyouireSHm38Mu2utyRPUACiS/KMps1GFZ8uNy+I/JZ1hVjiZulqHItvBSpPh/
Vaya0BupC9D6zNfp3lBjSJBgjuFSe+v2GCqjpcZIiACLs6t31J/jrzo1Sthc24jC
d15SD/H484P3r9yvERLwUMc7s+e8d4f9yFN3X2eIT1mKzrKbPlRZ4jKfmlHi2nO9
4mnfI2S7D6YpLTax997ESPb6KSLkcxstrT6ISham1sz2E3Ge/JbkJGrv4jZbgzot
KVO+I4BHVDHb8J5Rw8c2oUQsyqoEB3qHDVbnCZXsWRL8KLylVse+h01pp3zyuMTW
OmC0zLKY+4I1Webj9DCCaFlA8w3UDnD5AvEd3zU77RkShYop8MIU8ltvTbIOOyvH
NPejZKx0fPHksKEMypWWfF8z7LIMI+tVON2WJ5O4zKg5lh9X0a2MCRlYAAoxM3Gu
iSOEe6c/+CrnsVWlEynfUTshdU0FUxcw5296puQMEX52jQVBWHY8plIgoUdDW2j+
hz9CTaBt5uq46wb+KhOa
=IxJs
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] [PATCH 1/1] ARM: dts: Add LEDs on odroid XU3 board
2015-05-08 7:52 ` Krzysztof Kozlowski
@ 2015-05-08 9:10 ` Markus Reichl
2015-05-08 10:15 ` Anand Moon
0 siblings, 1 reply; 6+ messages in thread
From: Markus Reichl @ 2015-05-08 9:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-samsung-soc, Kukjin Kim; +Cc: Anand Moon
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
Hi Krzysztof,
Am 08.05.2015 um 09:52 schrieb Krzysztof Kozlowski:
> On 08.05.2015 16:34, Markus Reichl wrote:
>> This patch adds the RGB-LED on XU3 as 3 gpio-leds.
>
>> Tested-by: Anand Moon <linux.amoon@gmail.com>
>
> Unfortunately I could not found on LKML email from Anand that he
> tested it. You sent the patch first time on 2nd of April - without
> Anand's tested-by. On 13th of April it appeared with his tag.
>
> Guys, even when you work closely please send all tags publicly on LKML
> so everyone could see them.
>
> Anand, do you confirm the tested-by?
>
>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> --- It is
>> derived from hardkernel's 3.10 tree.
>
> Hmmm... Whose original code it was? Shouldn't there be someone else
> Signed-off-by here?
I sent a mail to HK guys to get the respective contact address for
another signed-off tag.
After this and Anand's tag I'll come back with a resend.
>
> Best regards,
> Krzysztof
>
>
Best Regards,
--
Markus Reichl
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] [PATCH 1/1] ARM: dts: Add LEDs on odroid XU3 board
2015-05-08 9:10 ` Markus Reichl
@ 2015-05-08 10:15 ` Anand Moon
0 siblings, 0 replies; 6+ messages in thread
From: Anand Moon @ 2015-05-08 10:15 UTC (permalink / raw)
To: Markus Reichl; +Cc: Krzysztof Kozlowski, linux-samsung-soc, Kukjin Kim
Hi Markus/Krzysztof,
Tested-by: Anand Moon <linux.amoon@gmail.com>
I have tested this patch.
-Anand Moon
On 8 May 2015 at 14:40, Markus Reichl <m.reichl@fivetechno.de> wrote:
> Hi Krzysztof,
>
> Am 08.05.2015 um 09:52 schrieb Krzysztof Kozlowski:
>> On 08.05.2015 16:34, Markus Reichl wrote:
>>> This patch adds the RGB-LED on XU3 as 3 gpio-leds.
>>
>>> Tested-by: Anand Moon <linux.amoon@gmail.com>
>>
>> Unfortunately I could not found on LKML email from Anand that he
>> tested it. You sent the patch first time on 2nd of April - without
>> Anand's tested-by. On 13th of April it appeared with his tag.
>>
>> Guys, even when you work closely please send all tags publicly on LKML
>> so everyone could see them.
>>
>> Anand, do you confirm the tested-by?
>>
>>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> --- It is
>>> derived from hardkernel's 3.10 tree.
>>
>> Hmmm... Whose original code it was? Shouldn't there be someone else
>> Signed-off-by here?
>
> I sent a mail to HK guys to get the respective contact address for
> another signed-off tag.
>
> After this and Anand's tag I'll come back with a resend.
>>
>> Best regards,
>> Krzysztof
>>
>>
> Best Regards,
> --
> Markus Reichl
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] [PATCH 1/1] ARM: dts: Add LEDs on odroid XU3 board
2015-05-08 7:34 Markus Reichl
2015-05-08 7:52 ` Krzysztof Kozlowski
@ 2015-05-08 18:59 ` Kukjin Kim
1 sibling, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2015-05-08 18:59 UTC (permalink / raw)
To: m.reichl; +Cc: linux-samsung-soc, Kukjin Kim, Krzysztof Kozlowski, Anand Moon
On 05/08/15 16:34, Markus Reichl wrote:
> This patch adds the RGB-LED on XU3 as 3 gpio-leds.
>
> Tested-by: Anand Moon <linux.amoon@gmail.com>
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> ---
> It is derived from hardkernel's 3.10 tree.
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index a519c86..0a32302 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -278,6 +278,30 @@
> rtc@101E0000 {
> status = "okay";
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + heartbeat {
> + label = "blue:heartbeart";
> + gpios = <&gpb2 2 0>;
> + default-state = "off";
> + linux,default-trigger = "heartbeat";
> + };
> +
> + eMMC {
> + label = "green:eMMC";
> + gpios = <&gpb2 1 0>;
> + default-state = "off";
> + linux,default-trigger = "mmc0";
> + };
> +
> + microSD {
> + label = "red:microSD";
> + gpios = <&gpx2 3 0>;
> + default-state = "off";
> + linux,default-trigger = "mmc1";
> + };
> + };
> };
>
> &hdmi {
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-08 18:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-13 8:43 [RESEND] [PATCH 1/1] ARM: dts: Add LEDs on odroid XU3 board Markus Reichl
-- strict thread matches above, loose matches on Subject: below --
2015-05-08 7:34 Markus Reichl
2015-05-08 7:52 ` Krzysztof Kozlowski
2015-05-08 9:10 ` Markus Reichl
2015-05-08 10:15 ` Anand Moon
2015-05-08 18:59 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox