[PATCH V4 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node

[PATCH V4 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node

[Markus Reichl]

The Exynos5422 SoC has a s3c6410 RTC where the source clock
is now a mandatory property.

This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
It is based on v4.0-rc2.

---
Changes since v3:
1. Readded slipped #include statement.
Sorry for the mess.
Changes since v2:
1. Dropped unused phandle.
Changes since v1:
1. Dropped Documentation.
2. Split into 2 parts.

Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index a519c86..d086398 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -11,6 +11,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/clock/samsung,s2mps11.h>
 #include "exynos5800.dtsi"
 
 / {
@@ -274,10 +275,6 @@
 			reg = <0x50>;
 		};
 	};
-
-	rtc@101E0000 {
-		status = "okay";
-	};
 };
 
 &hdmi {
@@ -369,3 +366,9 @@
 		shunt-resistor = <10000>;
 	};
 };
+
+&rtc {
+	status = "okay";
+	clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
+	clock-names = "rtc", "rtc_src";
+};
-- 
1.9.1

Re: [PATCH V4 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node

[Javier Martinez Canillas]

Hello Markus,

On 03/31/2015 01:48 PM, Markus Reichl wrote:
> The Exynos5422 SoC has a s3c6410 RTC where the source clock
> is now a mandatory property.
> 
> This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
> It is based on v4.0-rc2.
> 
> ---
> Changes since v3:
> 1. Readded slipped #include statement.
> Sorry for the mess.
> Changes since v2:
> 1. Dropped unused phandle.
> Changes since v1:
> 1. Dropped Documentation.
> 2. Split into 2 parts.
> 
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>

When you re-spin your patches with small changes, you should keep all
the {Reviewed,Tested,Acked}-by tags collected on previous versions so
the maintainer picking the patches knows who already reviewed the code.

Best regards,
Javier

Re: [PATCH V4 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node

[Markus Reichl]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

Am 31.03.2015 um 14:00 schrieb Javier Martinez Canillas:
> Hello Markus,
> 
> On 03/31/2015 01:48 PM, Markus Reichl wrote:
>> The Exynos5422 SoC has a s3c6410 RTC where the source clock
>> is now a mandatory property.
>>
>> This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
>> It is based on v4.0-rc2.
>>
>> ---
>> Changes since v3:
>> 1. Readded slipped #include statement.
>> Sorry for the mess.
>> Changes since v2:
>> 1. Dropped unused phandle.
>> Changes since v1:
>> 1. Dropped Documentation.
>> 2. Split into 2 parts.
>>
>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>>
> 
> When you re-spin your patches with small changes, you should keep all
> the {Reviewed,Tested,Acked}-by tags collected on previous versions so
> the maintainer picking the patches knows who already reviewed the code.
> 
> Best regards,
> Javier
> 
> 
Ok, will copy it in next time.

Thanks,
-- 
Markus Reichl


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH V4 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node

[Krzysztof Kozlowski]

W dniu 31.03.2015 o 20:48, Markus Reichl pisze:
> The Exynos5422 SoC has a s3c6410 RTC where the source clock
> is now a mandatory property.
> 
> This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
> It is based on v4.0-rc2.
> 
> ---
> Changes since v3:
> 1. Readded slipped #include statement.
> Sorry for the mess.
> Changes since v2:
> 1. Dropped unused phandle.
> Changes since v1:
> 1. Dropped Documentation.
> 2. Split into 2 parts.
> 
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>

Please re-send the patch with:
1. Accumulated reviews.
2. Signed-off-by and other tags BEFORE delimiter '---'

Best regards,
Krzysztof

[RESEND] [PATCH V4 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node

[Markus Reichl]

The Exynos5422 SoC has a s3c6410 RTC where the source clock
is now a mandatory property.

This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
It is based on v4.0-rc2.

Signed-off-by: Markus Reichl <m.reichl@fivetechno.de
Tested-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
Added accumulated reviews for RESEND
Changes since v3:
1. Readded slipped #include statement.
Sorry for the mess.
Changes since v2:
1. Dropped unused phandle.
Changes since v1:
1. Dropped Documentation.
2. Split into 2 parts.

---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index a519c86..d086398 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -11,6 +11,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/clock/samsung,s2mps11.h>
 #include "exynos5800.dtsi"
 
 / {
@@ -274,10 +275,6 @@
 			reg = <0x50>;
 		};
 	};
-
-	rtc@101E0000 {
-		status = "okay";
-	};
 };
 
 &hdmi {
@@ -369,3 +366,9 @@
 		shunt-resistor = <10000>;
 	};
 };
+
+&rtc {
+	status = "okay";
+	clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
+	clock-names = "rtc", "rtc_src";
+};
-- 
1.9.1