From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Gustavo Padovan <gustavo@padovan.org>, linux-samsung-soc@vger.kernel.org
Cc: tjakobi@math.uni-bielefeld.de,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v8 08/14] drm/exynos: atomic phase 3: use atomic .set_config helper
Date: Thu, 28 May 2015 17:25:10 +0900 [thread overview]
Message-ID: <5566D0E6.5060302@samsung.com> (raw)
In-Reply-To: <1432760183-4342-9-git-send-email-gustavo@padovan.org>
On 05/28/2015 05:56 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> Now that phase 1 and 2 are complete switch .set_config helper to
> use the atomic one.
>
> v2: also remove .prepare() callback
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Tested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
> drivers/gpu/drm/exynos/exynos_drm_crtc.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> index fe77516..c490064 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> @@ -50,11 +50,6 @@ static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode)
> drm_crtc_vblank_on(crtc);
> }
>
> -static void exynos_drm_crtc_prepare(struct drm_crtc *crtc)
> -{
> - /* drm framework doesn't check NULL. */
> -}
> -
> static void exynos_drm_crtc_commit(struct drm_crtc *crtc)
> {
> struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
> @@ -111,7 +106,6 @@ static void exynos_drm_crtc_disable(struct drm_crtc *crtc)
>
> static struct drm_crtc_helper_funcs exynos_crtc_helper_funcs = {
> .dpms = exynos_drm_crtc_dpms,
> - .prepare = exynos_drm_crtc_prepare,
As i said, can remove .prepare of drm_encoder_helper_funcs also.
> .commit = exynos_drm_crtc_commit,
> .mode_fixup = exynos_drm_crtc_mode_fixup,
> .mode_set = drm_helper_crtc_mode_set,
Also, can remove .mode_set and .mode_set_base because we use
drm_atomic_helper_set_config.
> @@ -193,7 +187,7 @@ static void exynos_drm_crtc_destroy(struct drm_crtc *crtc)
> }
>
> static struct drm_crtc_funcs exynos_crtc_funcs = {
> - .set_config = drm_crtc_helper_set_config,
> + .set_config = drm_atomic_helper_set_config,
> .page_flip = exynos_drm_crtc_page_flip,
> .destroy = exynos_drm_crtc_destroy,
> .reset = drm_atomic_helper_crtc_reset,
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-05-28 8:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 20:56 [PATCH v8 00/14] drm/exynos: atomic modesetting support Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 01/14] drm/exynos: fix source data argument for plane Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 02/14] drm/exynos: atomic phase 1: use drm_plane_helper_update() Gustavo Padovan
2015-05-28 8:24 ` Joonyoung Shim
2015-05-27 20:56 ` [PATCH v8 03/14] drm/exynos: atomic phase 1: use drm_plane_helper_disable() Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 04/14] drm/exynos: atomic phase 1: add .mode_set_nofb() callback Gustavo Padovan
2015-05-28 8:24 ` Joonyoung Shim
2015-05-29 6:21 ` Joonyoung Shim
2015-05-27 20:56 ` [PATCH v8 05/14] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy() Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 06/14] drm/exynos: atomic phase 2: keep track of framebuffer pointer Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 07/14] drm/exynos: atomic phase 3: atomic updates of planes Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 08/14] drm/exynos: atomic phase 3: use atomic .set_config helper Gustavo Padovan
2015-05-28 8:25 ` Joonyoung Shim [this message]
2015-05-27 20:56 ` [PATCH v8 09/14] drm/exynos: atomic phase 3: convert page flips Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 10/14] drm/exynos: remove exported functions from exynos_drm_plane Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 11/14] drm/exynos: don't disable unused functions at init Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 12/14] drm/exynos: move exynos_drm_crtc_disable() Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 13/14] drm/exynos: atomic dpms support Gustavo Padovan
2015-05-27 20:56 ` [PATCH v8 14/14] drm/exynos: remove unnecessary calls to disable_plane() Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5566D0E6.5060302@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=gustavo@padovan.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox