From: Inki Dae <inki.dae@samsung.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH v10 17/17] drm/exynos: split exynos_crtc->dpms in enable() and disable()
Date: Wed, 03 Jun 2015 10:08:47 +0900 [thread overview]
Message-ID: <556E539F.9080706@samsung.com> (raw)
In-Reply-To: <CABxcv=kwcnjudw0vQ1gHcoNfDC4xQGMu_WJTZ3_vhcxG70R02Q@mail.gmail.com>
On 2015년 06월 02일 23:19, Javier Martinez Canillas wrote:
> Hello Gustavo,
>
> On Tue, Jun 2, 2015 at 4:06 PM, Gustavo Padovan <gustavo@padovan.org> wrote:
>> Hi Inki,
>>
>> 2015-06-02 Inki Dae <inki.dae@samsung.com>:
>>
>>> Hi,
>>>
>>> On 2015년 06월 02일 00:04, Gustavo Padovan wrote:
>>>> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>>>
>>>> To follow more closely the new atomic API we split the dpms()
>>>> helper into the enable() and disable() helper to get exactly the
>>>> same semantics.
>>>
>>> Below is the result from checkpatch.pl. Please fix all errors and check
>>> your patch with checkpatch.pl before posting it.
>>>
>>> Thanks,
>>> Inki Dae
>>>
>>> total: 62 errors, 0 warnings, 410 lines checked
>>
>> I think you did something wrong when checking, for me it looks like
>> this:
>>
>> 0016-drm-exynos-split-exynos_crtc-dpms-in-enable-and-disa.patch has no
>> obvious style problems and is ready for submission.
>> WARNING: Do not use whitespace before Signed-off-by:
>> #12:
>> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>
>> total: 0 errors, 1 warnings, 594 lines checked
>>
>
> I also don't get any checkpatch.pl error or warnings when testing your patch:
>
> $ pwclient get 6523251
> Saved patch to v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch.0
>
> $ ./scripts/checkpatch.pl
> v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch
> total: 0 errors, 0 warnings, 410 lines checked
>
> v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch
> has no obvious style problems and is ready for submission.
Yes, there was something wrong. While coping this patch series to my PC,
it seems that the text format of this patch file was mutated.
Thanks for checking,
Inki Dae
>
>> Gustavo
>
> Best regards,
> Javier
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-06-03 1:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 15:04 [PATCH v10 00/17] drm/exynos: atomic modesetting support Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 01/17] drm/exynos: fix source data argument for plane Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 02/17] drm/exynos: use adjusted_mode of crtc_state instead of mode Gustavo Padovan
2015-06-01 15:09 ` Tobias Jakobi
2015-06-02 0:03 ` Joonyoung Shim
2015-06-02 12:12 ` Inki Dae
2015-06-02 14:09 ` Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 03/17] drm/exynos: atomic phase 1: use drm_plane_helper_update() Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 04/17] drm/exynos: atomic phase 1: use drm_plane_helper_disable() Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 05/17] drm/exynos: atomic phase 1: add .mode_set_nofb() callback Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 06/17] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy() Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 07/17] drm/exynos: atomic phase 2: keep track of framebuffer pointer Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 08/17] drm/exynos: atomic phase 3: atomic updates of planes Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 09/17] drm/exynos: atomic phase 3: use atomic .set_config helper Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 10/17] drm/exynos: atomic phase 3: convert page flips Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 11/17] drm/exynos: remove exported functions from exynos_drm_plane Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 12/17] drm/exynos: don't disable unused functions at init Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 13/17] drm/exynos: move exynos_drm_crtc_disable() Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 14/17] drm/exynos: add exynos specific .atomic_commit() Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 15/17] drm/exynos: atomic dpms support Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 16/17] drm/exynos: remove unnecessary calls to disable_plane() Gustavo Padovan
2015-06-01 15:04 ` [PATCH v10 17/17] drm/exynos: split exynos_crtc->dpms in enable() and disable() Gustavo Padovan
2015-06-02 12:09 ` Inki Dae
2015-06-02 14:06 ` Gustavo Padovan
2015-06-02 14:19 ` Javier Martinez Canillas
2015-06-03 1:08 ` Inki Dae [this message]
2015-06-03 7:53 ` Inki Dae
2015-06-03 13:20 ` Gustavo Padovan
2015-06-10 10:03 ` [PATCH v10 00/17] drm/exynos: atomic modesetting support Marek Szyprowski
2015-06-10 10:59 ` Inki Dae
2015-06-10 11:38 ` Marek Szyprowski
2015-06-10 12:08 ` Inki Dae
2015-06-10 13:36 ` Gustavo Padovan
2015-06-11 6:21 ` Joonyoung Shim
2015-06-11 14:01 ` Gustavo Padovan
2015-06-12 8:32 ` Joonyoung Shim
2015-06-15 6:09 ` Inki Dae
2015-06-16 20:35 ` Gustavo Padovan
2015-06-17 13:00 ` Inki Dae
2015-06-17 14:33 ` Gustavo Padovan
2015-06-18 4:36 ` Inki Dae
2015-06-19 12:20 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556E539F.9080706@samsung.com \
--to=inki.dae@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=javier@dowhile0.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox