From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "moderated list:ARM/S5P EXYNOS AR..."
<linux-samsung-soc@vger.kernel.org>,
gustavo.padovan@collabora.co.uk,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 4/9] tests/exynos: clean struct connector
Date: Fri, 12 Jun 2015 18:22:18 +0200 [thread overview]
Message-ID: <557B073A.5050401@math.uni-bielefeld.de> (raw)
In-Reply-To: <CACvgo538xoZ-z-C=WHdZiTd4BJRncf-g1v+AMb49Y2rYzU9b4A@mail.gmail.com>
Hello Emil,
Emil Velikov wrote:
> On 10 June 2015 at 14:42, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote:
>> Remove all unused struct members.
>>
> Mentioning if they were used at some point in the past will be great.
OK, I'll take a look at git history but AFAIK it is not.
With best wishes,
Tobias
>
> Thanks
> Emil
>
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>> tests/exynos/exynos_fimg2d_test.c | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c
>> index 64dacfa..6af9277 100644
>> --- a/tests/exynos/exynos_fimg2d_test.c
>> +++ b/tests/exynos/exynos_fimg2d_test.c
>> @@ -65,17 +65,9 @@ struct fimg2d_test_case {
>> struct connector {
>> uint32_t id;
>> char mode_str[64];
>> - char format_str[5];
>> - unsigned int fourcc;
>> drmModeModeInfo *mode;
>> drmModeEncoder *encoder;
>> int crtc;
>> - int pipe;
>> - int plane_zpos;
>> - unsigned int fb_id[2], current_fb_id;
>> - struct timeval start;
>> -
>> - int swap_count;
>> };
>>
>> static void connector_find_mode(int fd, struct connector *c,
>> @@ -750,8 +742,6 @@ int main(int argc, char **argv)
>> if (ret < 0)
>> goto err_destroy_buffer;
>>
>> - con.plane_zpos = -1;
>> -
>> memset(bo->vaddr, 0xff, screen_width * screen_height * 4);
>>
>> ret = drm_set_crtc(dev, &con, fb_id);
>> --
>> 2.0.5
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-06-12 16:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 13:42 [PATCH 0/9] drm/exynos: cleanups and small fixes for libdrm Tobias Jakobi
2015-06-10 13:42 ` [PATCH 1/9] exynos: fimg2d: fix return codes Tobias Jakobi
2015-06-12 15:57 ` Emil Velikov
2015-06-12 16:21 ` Tobias Jakobi
2015-06-10 13:42 ` [PATCH 2/9] tests/exynos: replace return by break Tobias Jakobi
2015-06-10 13:42 ` [PATCH 3/9] exynos/fimg2d: simplify g2d_fini() Tobias Jakobi
2015-06-10 13:42 ` [PATCH 4/9] tests/exynos: clean struct connector Tobias Jakobi
2015-06-12 15:59 ` Emil Velikov
2015-06-12 16:22 ` Tobias Jakobi [this message]
2015-06-10 13:42 ` [PATCH 5/9] tests/exynos: remove unused define Tobias Jakobi
2015-06-10 13:42 ` [PATCH 6/9] tests/exynos: remove struct fimg2d_test_case Tobias Jakobi
2015-06-12 16:06 ` Emil Velikov
2015-06-12 16:25 ` Tobias Jakobi
2015-06-12 16:41 ` Emil Velikov
2015-06-10 13:42 ` [PATCH 7/9] tests/exynos: simplify drm_set_crtc Tobias Jakobi
2015-06-10 13:42 ` [PATCH 8/9] tests/exynos: remove connector_find_plane Tobias Jakobi
2015-06-12 16:01 ` Emil Velikov
2015-06-10 13:42 ` [PATCH 9/9] tests/exynos: handle G2D_IMGBUF_COLOR in switch statements Tobias Jakobi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557B073A.5050401@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox