From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "moderated list:ARM/S5P EXYNOS AR..."
<linux-samsung-soc@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Joonyoung Shim <jy0922.shim@samsung.com>,
gustavo.padovan@collabora.co.uk, Inki Dae <inki.dae@samsung.com>
Subject: Re: [PATCH 6/9] tests/exynos: remove struct fimg2d_test_case
Date: Fri, 12 Jun 2015 18:25:21 +0200 [thread overview]
Message-ID: <557B07F1.6040400@math.uni-bielefeld.de> (raw)
In-Reply-To: <CACvgo51saXm3of0S2n_AL61X7KaoarrA_=Cc75ri==P=KH8jGA@mail.gmail.com>
Hello Emil,
Emil Velikov wrote:
> On 10 June 2015 at 14:42, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote:
>> It doesn't make sense to keep this structure, since we
>> can just call all tests directly.
>>
> Seems like it was designed in mind of having another test case.
> Perhaps the exynos guys cannot really upstream it (licensing or other
> issues) ?
might be. But why should we care about that anyway?
My personal guess: Big giant code bomb which noone bothered to check. ;)
With best wishes,
Tobias
>
> -Emil
>
next prev parent reply other threads:[~2015-06-12 16:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 13:42 [PATCH 0/9] drm/exynos: cleanups and small fixes for libdrm Tobias Jakobi
2015-06-10 13:42 ` [PATCH 1/9] exynos: fimg2d: fix return codes Tobias Jakobi
2015-06-12 15:57 ` Emil Velikov
2015-06-12 16:21 ` Tobias Jakobi
2015-06-10 13:42 ` [PATCH 2/9] tests/exynos: replace return by break Tobias Jakobi
2015-06-10 13:42 ` [PATCH 3/9] exynos/fimg2d: simplify g2d_fini() Tobias Jakobi
2015-06-10 13:42 ` [PATCH 4/9] tests/exynos: clean struct connector Tobias Jakobi
2015-06-12 15:59 ` Emil Velikov
2015-06-12 16:22 ` Tobias Jakobi
2015-06-10 13:42 ` [PATCH 5/9] tests/exynos: remove unused define Tobias Jakobi
2015-06-10 13:42 ` [PATCH 6/9] tests/exynos: remove struct fimg2d_test_case Tobias Jakobi
2015-06-12 16:06 ` Emil Velikov
2015-06-12 16:25 ` Tobias Jakobi [this message]
2015-06-12 16:41 ` Emil Velikov
2015-06-10 13:42 ` [PATCH 7/9] tests/exynos: simplify drm_set_crtc Tobias Jakobi
2015-06-10 13:42 ` [PATCH 8/9] tests/exynos: remove connector_find_plane Tobias Jakobi
2015-06-12 16:01 ` Emil Velikov
2015-06-10 13:42 ` [PATCH 9/9] tests/exynos: handle G2D_IMGBUF_COLOR in switch statements Tobias Jakobi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557B07F1.6040400@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox