From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org
Cc: Andrzej Hajda <a.hajda@samsung.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos/fimc: fix runtime pm support
Date: Sun, 12 Jul 2015 18:24:59 +0200 [thread overview]
Message-ID: <55A294DB.7090800@math.uni-bielefeld.de> (raw)
In-Reply-To: <1428569160-20628-1-git-send-email-m.szyprowski@samsung.com>
Hello,
looks like this patch was forgotten. At least I can't find it in 4.2-rc1.
With best wishes,
Tobias
Marek Szyprowski wrote:
> Once pm_runtime_set_active() gets called, the kernel assumes that given
> device has already enabled runtime pm and will call pm_runtime_suspend()
> without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
> this will result in calling clk_disable() without respective call to
> clk_enable(). This patch removes call to pm_runtime_set_active() to
> ensure that pm_runtime_suspend/resume calls will match.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> index 842d6b8dc3c4..2a652359af64 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
> @@ -1745,7 +1745,6 @@ static int fimc_probe(struct platform_device *pdev)
> spin_lock_init(&ctx->lock);
> platform_set_drvdata(pdev, ctx);
>
> - pm_runtime_set_active(dev);
> pm_runtime_enable(dev);
>
> ret = exynos_drm_ippdrv_register(ippdrv);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-12 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 8:46 [PATCH] drm/exynos/fimc: fix runtime pm support Marek Szyprowski
2015-07-12 16:24 ` Tobias Jakobi [this message]
2015-08-06 10:13 ` Marek Szyprowski
2015-08-06 11:57 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A294DB.7090800@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox