From: Inki Dae <inki.dae@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
jy0922.shim@samsung.com
Subject: Re: [PATCH] drm/exynos/fimc: fix runtime pm support
Date: Thu, 06 Aug 2015 20:57:20 +0900 [thread overview]
Message-ID: <55C34BA0.4080100@samsung.com> (raw)
In-Reply-To: <55C3334B.9060907@samsung.com>
On 2015년 08월 06일 19:13, Marek Szyprowski wrote:
> Hello,
>
> On 2015-04-09 10:46, Marek Szyprowski wrote:
>> Once pm_runtime_set_active() gets called, the kernel assumes that given
>> device has already enabled runtime pm and will call pm_runtime_suspend()
>> without matching pm_runtime_resume(). In case of DRM FIMC IPP driver,
>> this will result in calling clk_disable() without respective call to
>> clk_enable(). This patch removes call to pm_runtime_set_active() to
>> ensure that pm_runtime_suspend/resume calls will match.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> Gentle ping...
Sorry, I missed it. Merged.
Thanks,
Inki Dae
>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> index 842d6b8dc3c4..2a652359af64 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
>> @@ -1745,7 +1745,6 @@ static int fimc_probe(struct platform_device *pdev)
>> spin_lock_init(&ctx->lock);
>> platform_set_drvdata(pdev, ctx);
>> - pm_runtime_set_active(dev);
>> pm_runtime_enable(dev);
>> ret = exynos_drm_ippdrv_register(ippdrv);
>
> Best regards
prev parent reply other threads:[~2015-08-06 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 8:46 [PATCH] drm/exynos/fimc: fix runtime pm support Marek Szyprowski
2015-07-12 16:24 ` Tobias Jakobi
2015-08-06 10:13 ` Marek Szyprowski
2015-08-06 11:57 ` Inki Dae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C34BA0.4080100@samsung.com \
--to=inki.dae@samsung.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox