Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Inki Dae <inki.dae@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init
Date: Tue, 18 Nov 2014 10:41:44 -0800	[thread overview]
Message-ID: <7hh9xwxsev.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1416318821-7925-1-git-send-email-javier.martinez@collabora.co.uk> (Javier Martinez Canillas's message of "Tue, 18 Nov 2014 14:53:41 +0100")

Javier Martinez Canillas <javier.martinez@collabora.co.uk> writes:

> The Exynos DRM driver register its sub-devices platform drivers in
> the probe function but after commit 43c0767 ("of/platform: Move
> platform devices under /sys/devices/platform"), this is causing
> a deadlock in __driver_attach(). Fix this by moving the platform
> drivers registration to exynos_drm_init().
>
> Suggested-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> This issue was reported by both Krzysztof Kozlowski [0] and Kevin Hilman [1].
>
> Inki Dae said that he will fix it property by separating the Exynos DRM
> driver in different sub-modules but I post this patch as RFC anyways so
> others can test if this fixes their boot issue.

It fixes the DRM deadlock, issue for me on exynos5800-peach-pi, but then
it proceeds to panic in the workqueue code called by the asoc max98090
codec[1].

If I then disable CONFIG_SND_SOC_SNOW, I can get it to boot to a shell,
but I still don't have display output.

Is anyone at Samsung testing linux-next?  If so, on what platforms?  It
would really be nice if your linux-next work was tested on these
publically-available 542x/5800 platforms (peach-pi, peach-pit,
odroid-xu3) which would also allow lots of others to help you test and
validate.

Kevin

  reply	other threads:[~2014-11-18 18:41 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 13:53 [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init Javier Martinez Canillas
2014-11-18 18:41 ` Kevin Hilman [this message]
2014-11-18 20:28   ` Gustavo Padovan
2014-11-18 22:46     ` Kevin Hilman
2014-11-19 10:09       ` Javier Martinez Canillas
2014-11-19 16:52   ` Javier Martinez Canillas
2014-11-19 19:52     ` Kevin Hilman
2014-11-19 22:29       ` Kevin Hilman
2014-11-20  7:06     ` Vivek Gautam
2014-11-20  7:51       ` Vivek Gautam
2014-11-20  8:45         ` Javier Martinez Canillas
2014-11-20  9:52           ` Vivek Gautam
2014-11-20 14:24             ` Pankaj Dubey
2014-11-20 15:57             ` Paolo Pisati
2014-11-20 16:44               ` Javier Martinez Canillas
2014-11-20 16:41       ` Kevin Hilman
2014-11-20 17:47         ` Javier Martinez Canillas
2014-11-20 18:22           ` Kevin Hilman
2014-11-20 23:49             ` Paolo Pisati
2014-11-21 11:33               ` Andreas Färber
2014-11-21 17:32                 ` Ajay kumar
2014-11-21 20:57                   ` Javier Martinez Canillas
2014-11-24 10:05                     ` Javier Martinez Canillas
2014-11-24 10:36                       ` Vivek Gautam
2014-11-24 15:05                       ` Andreas Färber
2014-11-25  5:35                         ` Ajay kumar
2014-11-21 13:03             ` Peach Pi/Pit boot failures in linux-next (was Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init) Javier Martinez Canillas
2014-11-21 16:38               ` Kevin Hilman
2014-11-21 20:49                 ` Javier Martinez Canillas
2014-11-22 10:21                   ` Krzysztof Kozlowski
2014-11-24  9:38                     ` Javier Martinez Canillas
2014-11-24  9:42                       ` Javier Martinez Canillas
2014-11-24 10:13                       ` Krzysztof Kozlowski
2014-11-24 11:07                         ` Javier Martinez Canillas
2014-11-24 11:12                           ` Krzysztof Kozlowski
2014-11-24 13:16                             ` Javier Martinez Canillas
2014-11-24 13:28                               ` Vivek Gautam
2014-11-24 13:53                               ` Krzysztof Kozlowski
2014-11-24  9:51                   ` Krzysztof Kozlowski
2014-11-20 14:07 ` [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init Inki Dae
2014-11-20 14:28   ` Javier Martinez Canillas
2014-11-20 15:06     ` Inki Dae
2014-11-20 15:26       ` Javier Martinez Canillas
2014-11-20 17:01         ` Inki Dae
2014-11-21 11:19           ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hh9xwxsev.fsf@deeprootsystems.com \
    --to=khilman@kernel.org \
    --cc=a.hajda@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox