Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Peter Chubb <peter.chubb@nicta.com.au>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Peter Chubb <peter.chubb@nicta.com.au>,
	kgene@kernel.org, linux-samsung-soc@vger.kernel.org
Subject: [PATCH v2] ARM: dts: Odroid XU3 -- Hook up PWM and use it for LEDs
Date: Tue, 12 May 2015 10:29:57 +1000	[thread overview]
Message-ID: <84pp66k1aa.wl-peter.chubb@nicta.com.au> (raw)
In-Reply-To: <CAJKOXPcPGHcP26hLK0V0Rrr3ABB+HQAqQg4PpZN7ytsn2O78Qg@mail.gmail.com>


PWM output wasn't working because it wasn't hooked up to its pincontrol.
This patch:
   -- hooks up PWM to its pincontrol, and documents what
      the outputs are on the XU3
   -- switches the LEDs that are on PWM outputs to use PWM
      rather than GPIO.

The main effect is that the brightness of the LEDs can be controlled, and
user-mode fan control is enabled via /sys/class/pwm

Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 58 +++++++++++++++++++++---------
 1 file changed, 41 insertions(+), 17 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 026f83e..095282b 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -13,6 +13,7 @@
 /dts-v1/;
 #include <dt-bindings/gpio/gpio.h>
 #include "exynos5800.dtsi"
+#include <dt-bindings/gpio/gpio.h>

 / {
        model = "Hardkernel Odroid XU3";
@@ -287,25 +288,35 @@
                status = "okay";
        };

-       leds {
-               compatible = "gpio-leds";
-               heartbeat {
-                       label = "blue:heartbeart";
-                       gpios = <&gpb2 2 0>;
-                       default-state = "off";
-                       linux,default-trigger = "heartbeat";
-               };
-
-               eMMC {
-                       label = "green:eMMC";
-                       gpios = <&gpb2 1 0>;
-                       default-state = "off";
-                       linux,default-trigger = "mmc0";
-               };
+       pwmleds {
+            compatible = "pwm-leds";
+
+            greenled {
+                    label = "green:mmc0";
+                    pwms = <&pwm 1 2000000 0>;
+                    pwm-names = "pwm1";
+                    /*
+                     * Green LED is much brighter than the others
+                     * so limit its max brightness
+                     */
+                    max_brightness = <127>;
+                    linux,default-trigger = "mmc0";
+            };
+
+            blueled {
+                    label = "blue:heartbeat";
+                    pwms = <&pwm 2 2000000 0>;
+                    pwm-names = "pwm2";
+                    max_brightness = <255>;
+                    linux,default-trigger = "heartbeat";
+            };
+       };

-               microSD {
+       gpioleds {
+               compatible = "gpio-leds";
+               redled {
                        label = "red:microSD";
-                       gpios = <&gpx2 3 0>;
+                       gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>;
                        default-state = "off";
                        linux,default-trigger = "mmc1";
                };
@@ -411,3 +422,16 @@
                shunt-resistor = <10000>;
        };
 };
+
+&pwm {
+       /*
+        * PWM 0 -- fan
+        * PWM 1 -- Green LED
+        * PWM 2 -- Blue LED
+        * PWM 3 -- on MIPI connector for backlight
+        */
+       pinctrl-0 = <&pwm0_out &pwm1_out &pwm2_out &pwm3_out>;
+       pinctrl-names = "default";
+       status = "okay";
+};
+
--
2.1.4



--
Dr Peter Chubb                                  peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au          Software Systems Research Group/NICTA

________________________________

The information in this e-mail may be confidential and subject to legal professional privilege and/or copyright. National ICT Australia Limited accepts no liability for any damage caused by this email or its attachments.

  reply	other threads:[~2015-05-12  1:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12  0:29 [PATCH] Odroid XU3 DTS: Hook up PWM and use it for LEDs Peter Chubb
2015-05-12  1:15 ` Krzysztof Kozlowski
2015-05-12  1:25   ` Peter Chubb
2015-05-12  1:37     ` Krzysztof Kozlowski
2015-05-12  0:29       ` Peter Chubb [this message]
2015-05-12  2:32         ` [PATCH v2] ARM: dts: Odroid XU3 -- " Krzysztof Kozlowski
2015-05-12  3:26         ` Krzysztof Kozlowski
2015-05-12 17:47         ` Kukjin Kim
2015-05-13  4:01         ` [PATCH v3] ARM: dts: exynos5422-odroidxu3: " Peter Chubb
2015-05-13 13:17           ` Krzysztof Kozlowski
2015-05-13 23:14             ` Peter Chubb
2015-05-13 23:57               ` [PATCH v4] " Peter Chubb
2015-07-30 20:09                 ` Anand Moon
2015-07-31 23:23                   ` Peter Chubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84pp66k1aa.wl-peter.chubb@nicta.com.au \
    --to=peter.chubb@nicta.com.au \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox