From: Peter Chubb <peter.chubb@nicta.com.au>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Peter Chubb <peter.chubb@nicta.com.au>,
kgene@kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v3] ARM: dts: exynos5422-odroidxu3: Hook up PWM and use it for LEDs
Date: Thu, 14 May 2015 09:14:43 +1000 [thread overview]
Message-ID: <84sib0gjdo.wl-peter.chubb@nicta.com.au> (raw)
In-Reply-To: <55534EF2.1090307@samsung.com>
>>>>> "Krzysztof" == Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
Krzysztof> W dniu 13.05.2015 o 13:01, Peter Chubb pisze:
Krzysztof> Please run checkpatch before sending a patch. Here you have
Krzysztof> trailing whitespace error.
Arrgh --- thanks for spotting that.
Krzysztof> Additionally the indentation is broken in most of the lines
Krzysztof> - mixed tabs with spaces. Just stick to the kernel coding
Krzysztof> convention - tabs (8 characters wide).
And that. I'm working on another project simultaneously that uses
4-space indent, and must have forgotten to reset Emacs's indent rules.
Krzysztof> Best regards, Krzysztof
V4 coming soon.
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA
next prev parent reply other threads:[~2015-05-13 23:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 0:29 [PATCH] Odroid XU3 DTS: Hook up PWM and use it for LEDs Peter Chubb
2015-05-12 1:15 ` Krzysztof Kozlowski
2015-05-12 1:25 ` Peter Chubb
2015-05-12 1:37 ` Krzysztof Kozlowski
2015-05-12 0:29 ` [PATCH v2] ARM: dts: Odroid XU3 -- " Peter Chubb
2015-05-12 2:32 ` Krzysztof Kozlowski
2015-05-12 3:26 ` Krzysztof Kozlowski
2015-05-12 17:47 ` Kukjin Kim
2015-05-13 4:01 ` [PATCH v3] ARM: dts: exynos5422-odroidxu3: " Peter Chubb
2015-05-13 13:17 ` Krzysztof Kozlowski
2015-05-13 23:14 ` Peter Chubb [this message]
2015-05-13 23:57 ` [PATCH v4] " Peter Chubb
2015-07-30 20:09 ` Anand Moon
2015-07-31 23:23 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84sib0gjdo.wl-peter.chubb@nicta.com.au \
--to=peter.chubb@nicta.com.au \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox