From: Jingoo Han <jg1.han@samsung.com>
To: 'James Bottomley' <JBottomley@Parallels.com>
Cc: 'James Bottomley' <jejb@kernel.org>,
linux-scsi@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>,
'Anil Ravindranath' <anil_ravindranath@pmc-sierra.com>,
'Andy Shevchenko' <andy.shevchenko@gmail.com>
Subject: [PATCH V2] scsi: replace strict_strtoul() with kstrtoul()
Date: Mon, 03 Jun 2013 18:06:12 +0900 [thread overview]
Message-ID: <000f01ce6039$984e6540$c8eb2fc0$@samsung.com> (raw)
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Changes since v1:
- Used return code from kstrtoul().
drivers/scsi/pmcraid.c | 6 ++++--
drivers/scsi/scsi_sysfs.c | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 8e1b737..39b42a4 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4203,9 +4203,11 @@ static ssize_t pmcraid_store_log_level(
struct Scsi_Host *shost;
struct pmcraid_instance *pinstance;
unsigned long val;
+ int ret;
- if (strict_strtoul(buf, 10, &val))
- return -EINVAL;
+ ret = kstrtoul(buf, 10, &val);
+ if (ret)
+ return ret;
/* log-level should be from 0 to 2 */
if (val > 2)
return -EINVAL;
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 931a7d9..4a8b675 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -789,9 +789,11 @@ sdev_store_queue_ramp_up_period(struct device *dev,
{
struct scsi_device *sdev = to_scsi_device(dev);
unsigned long period;
+ int ret;
- if (strict_strtoul(buf, 10, &period))
- return -EINVAL;
+ ret = kstrtoul(buf, 10, &period);
+ if (ret)
+ return ret;
sdev->queue_ramp_up_period = msecs_to_jiffies(period);
return period;
--
1.7.10.4
next reply other threads:[~2013-06-03 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 9:06 Jingoo Han [this message]
2013-06-03 10:51 ` [PATCH V2] scsi: replace strict_strtoul() with kstrtoul() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01ce6039$984e6540$c8eb2fc0$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=JBottomley@Parallels.com \
--cc=andy.shevchenko@gmail.com \
--cc=anil_ravindranath@pmc-sierra.com \
--cc=jejb@kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox