[PATCH V2] scsi: replace strict_strtoul() with kstrtoul()

[PATCH V2] scsi: replace strict_strtoul() with kstrtoul()

[Jingoo Han]

The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Changes since v1:
- Used return code from kstrtoul().

 drivers/scsi/pmcraid.c    |    6 ++++--
 drivers/scsi/scsi_sysfs.c |    6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 8e1b737..39b42a4 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4203,9 +4203,11 @@ static ssize_t pmcraid_store_log_level(
 	struct Scsi_Host *shost;
 	struct pmcraid_instance *pinstance;
 	unsigned long val;
+	int ret;
 
-	if (strict_strtoul(buf, 10, &val))
-		return -EINVAL;
+	ret = kstrtoul(buf, 10, &val);
+	if (ret)
+		return ret;
 	/* log-level should be from 0 to 2 */
 	if (val > 2)
 		return -EINVAL;
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 931a7d9..4a8b675 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -789,9 +789,11 @@ sdev_store_queue_ramp_up_period(struct device *dev,
 {
 	struct scsi_device *sdev = to_scsi_device(dev);
 	unsigned long period;
+	int ret;
 
-	if (strict_strtoul(buf, 10, &period))
-		return -EINVAL;
+	ret = kstrtoul(buf, 10, &period);
+	if (ret)
+		return ret;
 
 	sdev->queue_ramp_up_period = msecs_to_jiffies(period);
 	return period;
-- 
1.7.10.4

Re: [PATCH V2] scsi: replace strict_strtoul() with kstrtoul()

[Andy Shevchenko]

On Mon, Jun 3, 2013 at 12:06 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> ---
> Changes since v1:
> - Used return code from kstrtoul().
>
>  drivers/scsi/pmcraid.c    |    6 ++++--
>  drivers/scsi/scsi_sysfs.c |    6 ++++--
>  2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 8e1b737..39b42a4 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4203,9 +4203,11 @@ static ssize_t pmcraid_store_log_level(
>         struct Scsi_Host *shost;
>         struct pmcraid_instance *pinstance;
>         unsigned long val;
> +       int ret;
>
> -       if (strict_strtoul(buf, 10, &val))
> -               return -EINVAL;
> +       ret = kstrtoul(buf, 10, &val);
> +       if (ret)
> +               return ret;
>         /* log-level should be from 0 to 2 */
>         if (val > 2)
>                 return -EINVAL;
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 931a7d9..4a8b675 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -789,9 +789,11 @@ sdev_store_queue_ramp_up_period(struct device *dev,
>  {
>         struct scsi_device *sdev = to_scsi_device(dev);
>         unsigned long period;
> +       int ret;
>
> -       if (strict_strtoul(buf, 10, &period))
> -               return -EINVAL;
> +       ret = kstrtoul(buf, 10, &period);
> +       if (ret)
> +               return ret;
>
>         sdev->queue_ramp_up_period = msecs_to_jiffies(period);
>         return period;
> --
> 1.7.10.4
>
>



--
With Best Regards,
Andy Shevchenko