[PATCH V2 4/8] [SCSI] megaraid: add missing __iomem annotation

[PATCH V2 4/8] [SCSI] megaraid: add missing __iomem annotation

[Jingoo Han]

Added missing __iomem annotation in order to fix the following
sparse warnings:

drivers/scsi/megaraid.c:4595:26: warning: incorrect type in argument 1 (different address spaces)
drivers/scsi/megaraid.c:4595:26:    expected void volatile [noderef] <asn:2>*addr
drivers/scsi/megaraid.c:4595:26:    got void *<noident>
drivers/scsi/megaraid.c:4653:26: warning: incorrect type in argument 1 (different address spaces)
drivers/scsi/megaraid.c:4653:26:    expected void volatile [noderef] <asn:2>*addr
drivers/scsi/megaraid.c:4653:26:    got void *<noident>

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
No changes since v1:

 drivers/scsi/megaraid.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 90c95a3..a395207 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -4592,7 +4592,7 @@ megaraid_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	scsi_host_put(host);
  out_iounmap:
 	if (flag & BOARD_MEMMAP)
-		iounmap((void *)mega_baseport);
+		iounmap((void __iomem *)mega_baseport);
  out_release_region:
 	if (flag & BOARD_MEMMAP)
 		release_mem_region(tbase, 128);
@@ -4650,7 +4650,7 @@ megaraid_remove_one(struct pci_dev *pdev)
 
 	/* Free our resources */
 	if (adapter->flag & BOARD_MEMMAP) {
-		iounmap((void *)adapter->base);
+		iounmap((void __iomem *)adapter->base);
 		release_mem_region(adapter->host->base, 128);
 	} else
 		release_region(adapter->base, 16);
-- 
1.7.10.4

RE: [PATCH V2 4/8] [SCSI] megaraid: add missing __iomem annotation

[Saxena, Sumit]

>-----Original Message-----
>From: Jingoo Han [mailto:jg1.han@samsung.com]
>Sent: Thursday, August 08, 2013 6:46 AM
>To: 'James Bottomley'
>Cc: DL-MegaRAID Linux; 'James Bottomley'; linux-scsi@vger.kernel.org;
>Jingoo Han
>Subject: [PATCH V2 4/8] [SCSI] megaraid: add missing __iomem annotation
>
>Added missing __iomem annotation in order to fix the following sparse
>warnings:
>
>drivers/scsi/megaraid.c:4595:26: warning: incorrect type in argument 1
>(different address spaces)
>drivers/scsi/megaraid.c:4595:26:    expected void volatile [noderef]
><asn:2>*addr
>drivers/scsi/megaraid.c:4595:26:    got void *<noident>
>drivers/scsi/megaraid.c:4653:26: warning: incorrect type in argument 1
>(different address spaces)
>drivers/scsi/megaraid.c:4653:26:    expected void volatile [noderef]
><asn:2>*addr
>drivers/scsi/megaraid.c:4653:26:    got void *<noident>
>
>Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>---
>No changes since v1:
>
> drivers/scsi/megaraid.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index
>90c95a3..a395207 100644
>--- a/drivers/scsi/megaraid.c
>+++ b/drivers/scsi/megaraid.c
>@@ -4592,7 +4592,7 @@ megaraid_probe_one(struct pci_dev *pdev, const
>struct pci_device_id *id)
> 	scsi_host_put(host);
>  out_iounmap:
> 	if (flag & BOARD_MEMMAP)
>-		iounmap((void *)mega_baseport);
>+		iounmap((void __iomem *)mega_baseport);
>  out_release_region:
> 	if (flag & BOARD_MEMMAP)
> 		release_mem_region(tbase, 128);
>@@ -4650,7 +4650,7 @@ megaraid_remove_one(struct pci_dev *pdev)
>
> 	/* Free our resources */
> 	if (adapter->flag & BOARD_MEMMAP) {
>-		iounmap((void *)adapter->base);
>+		iounmap((void __iomem *)adapter->base);
> 		release_mem_region(adapter->host->base, 128);
> 	} else
> 		release_region(adapter->base, 16);
>--
>1.7.10.4
>
>
Acked-by: Sumit Saxena <sumit.saxena@lsi.com>


Sumit