* [PATCH] scsi: The supplement for the arithmetic of iomem of the Type_B Adapter of arcmsr
@ 2008-03-14 12:51 nickcheng
2008-03-14 20:03 ` Andrew Morton
2008-03-14 20:26 ` James Bottomley
0 siblings, 2 replies; 4+ messages in thread
From: nickcheng @ 2008-03-14 12:51 UTC (permalink / raw)
To: James.Bottomley
Cc: linux-scsi, randy.dunlap, 'Tomas Henzl', viro,
'Andrew Morton'
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
Subject: [PATCH] scsi: The supplement for the arithmetic of iomem of the
Type_B Adapter
Description:
add the description for the change of the arithmetic of iomem of the Type_B
Adapter in ChangeLog.arcmsr
Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
[-- Attachment #2: patch-ChangeLog.arcmsr.txt --]
[-- Type: text/plain, Size: 753 bytes --]
--- ChangeLog.arcmsr.old 2008-03-14 20:15:07.000000000 +0800
+++ ChangeLog.arcmsr.new 2008-03-14 20:02:12.000000000 +0800
@@ -115,4 +115,8 @@
** that the current GFP_KERNEL|GFP_DMA flags are wrong: firstly we are in
** atomic context, secondly this memory is not used for DMA.
** Also removed some unneeded casts. Thanks to Daniel Drake <dsd@gentoo.org>
+** 2.The Type B Adapter teardown does iounmap on pointers subtracted by a
+** constant offset. Since the offset is in bytes, we need the pointers to
+** be of type void * not uint32_t * so the subtraction is done in the
+** correct units and we iounmap the correct area.
**************************************************************************
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: The supplement for the arithmetic of iomem of the Type_B Adapter of arcmsr
2008-03-14 12:51 [PATCH] scsi: The supplement for the arithmetic of iomem of the Type_B Adapter of arcmsr nickcheng
@ 2008-03-14 20:03 ` Andrew Morton
2008-03-14 20:26 ` James Bottomley
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2008-03-14 20:03 UTC (permalink / raw)
To: nick.cheng; +Cc: James.Bottomley, linux-scsi, randy.dunlap, thenzl, viro
On Fri, 14 Mar 2008 20:51:17 +0800
"nickcheng" <nick.cheng@areca.com.tw> wrote:
> [patch-ChangeLog.arcmsr.txt text/plain (764B)]
> ___--- ChangeLog.arcmsr.old 2008-03-14 20:15:07.000000000 +0800
> +++ ChangeLog.arcmsr.new 2008-03-14 20:02:12.000000000 +0800
> @@ -115,4 +115,8 @@
This patch had three weird non-ascii characters at the start.
Please prepare patches in `patch -p1' form. So the patch will apply with
`patch -p1' from within the kernel's top-level directory.
I fixed both the above problems.
Does this file actually need to exist? We prefer to get our changelog
information from `git-log', not from a standalone file.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: The supplement for the arithmetic of iomem of the Type_B Adapter of arcmsr
2008-03-14 12:51 [PATCH] scsi: The supplement for the arithmetic of iomem of the Type_B Adapter of arcmsr nickcheng
2008-03-14 20:03 ` Andrew Morton
@ 2008-03-14 20:26 ` James Bottomley
2008-03-17 2:08 ` [PATCH] scsi: The supplement for the arithmetic of iomem ofthe " nickcheng
1 sibling, 1 reply; 4+ messages in thread
From: James Bottomley @ 2008-03-14 20:26 UTC (permalink / raw)
To: nick.cheng
Cc: linux-scsi, randy.dunlap, 'Tomas Henzl', viro,
'Andrew Morton'
On Fri, 2008-03-14 at 20:51 +0800, nickcheng wrote:
> Subject: [PATCH] scsi: The supplement for the arithmetic of iomem of the
> Type_B Adapter
> Description:
> add the description for the change of the arithmetic of iomem of the Type_B
> Adapter in ChangeLog.arcmsr
> Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
I confused you when I said I want the change log clearer, didn't I? What
I meant was the *git* changelog that precedes the patch, not your
Changelog.arcmsr, which I don't think we really care about.
Can I suggest the below for the correct replacement for both of these
patches?
James
---
From: nickcheng <nick.cheng@areca.com.tw>
Subject: [SCSI] arcmsr: fix iounmap error for Type B adapter
The Type B Adapter teardown does iounmap on pointers subtracted by a
constant offset. Since the offset is in bytes, we need the pointers to
be of type void * not uint32_t * so the subtraction is done in the
correct units and we iounmap the correct area.
Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
drivers/scsi/arcmsr/arcmsr.h | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h
index 0393707..3288be2 100644
--- a/drivers/scsi/arcmsr/arcmsr.h
+++ b/drivers/scsi/arcmsr/arcmsr.h
@@ -341,13 +341,13 @@ struct MessageUnit_B
uint32_t done_qbuffer[ARCMSR_MAX_HBB_POSTQUEUE];
uint32_t postq_index;
uint32_t doneq_index;
- uint32_t __iomem *drv2iop_doorbell_reg;
- uint32_t __iomem *drv2iop_doorbell_mask_reg;
- uint32_t __iomem *iop2drv_doorbell_reg;
- uint32_t __iomem *iop2drv_doorbell_mask_reg;
- uint32_t __iomem *msgcode_rwbuffer_reg;
- uint32_t __iomem *ioctl_wbuffer_reg;
- uint32_t __iomem *ioctl_rbuffer_reg;
+ void __iomem *drv2iop_doorbell_reg;
+ void __iomem *drv2iop_doorbell_mask_reg;
+ void __iomem *iop2drv_doorbell_reg;
+ void __iomem *iop2drv_doorbell_mask_reg;
+ void __iomem *msgcode_rwbuffer_reg;
+ void __iomem *ioctl_wbuffer_reg;
+ void __iomem *ioctl_rbuffer_reg;
};
/*
--
1.5.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: The supplement for the arithmetic of iomem ofthe Type_B Adapter of arcmsr
2008-03-14 20:26 ` James Bottomley
@ 2008-03-17 2:08 ` nickcheng
0 siblings, 0 replies; 4+ messages in thread
From: nickcheng @ 2008-03-17 2:08 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, randy.dunlap, 'Tomas Henzl', viro,
'Andrew Morton'
Hi James,
What a mess I made!! Terrible
As you suggest, I agree with you. (I hope this time I don't misconstrue
again.)
Thanks,
-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
Sent: Saturday, March 15, 2008 4:27 AM
To: nick.cheng@areca.com.tw
Cc: linux-scsi@vger.kernel.org; randy.dunlap@oracle.com; 'Tomas Henzl';
viro@ftp.linux.org.uk; 'Andrew Morton'
Subject: Re: [PATCH] scsi: The supplement for the arithmetic of iomem ofthe
Type_B Adapter of arcmsr
On Fri, 2008-03-14 at 20:51 +0800, nickcheng wrote:
> Subject: [PATCH] scsi: The supplement for the arithmetic of iomem of the
> Type_B Adapter
> Description:
> add the description for the change of the arithmetic of iomem of the
Type_B
> Adapter in ChangeLog.arcmsr
> Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
I confused you when I said I want the change log clearer, didn't I? What
I meant was the *git* changelog that precedes the patch, not your
Changelog.arcmsr, which I don't think we really care about.
Can I suggest the below for the correct replacement for both of these
patches?
James
---
From: nickcheng <nick.cheng@areca.com.tw>
Subject: [SCSI] arcmsr: fix iounmap error for Type B adapter
The Type B Adapter teardown does iounmap on pointers subtracted by a
constant offset. Since the offset is in bytes, we need the pointers to
be of type void * not uint32_t * so the subtraction is done in the
correct units and we iounmap the correct area.
Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
drivers/scsi/arcmsr/arcmsr.h | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h
index 0393707..3288be2 100644
--- a/drivers/scsi/arcmsr/arcmsr.h
+++ b/drivers/scsi/arcmsr/arcmsr.h
@@ -341,13 +341,13 @@ struct MessageUnit_B
uint32_t done_qbuffer[ARCMSR_MAX_HBB_POSTQUEUE];
uint32_t postq_index;
uint32_t doneq_index;
- uint32_t __iomem *drv2iop_doorbell_reg;
- uint32_t __iomem *drv2iop_doorbell_mask_reg;
- uint32_t __iomem *iop2drv_doorbell_reg;
- uint32_t __iomem *iop2drv_doorbell_mask_reg;
- uint32_t __iomem *msgcode_rwbuffer_reg;
- uint32_t __iomem *ioctl_wbuffer_reg;
- uint32_t __iomem *ioctl_rbuffer_reg;
+ void __iomem *drv2iop_doorbell_reg;
+ void __iomem *drv2iop_doorbell_mask_reg;
+ void __iomem *iop2drv_doorbell_reg;
+ void __iomem *iop2drv_doorbell_mask_reg;
+ void __iomem *msgcode_rwbuffer_reg;
+ void __iomem *ioctl_wbuffer_reg;
+ void __iomem *ioctl_rbuffer_reg;
};
/*
--
1.5.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-03-17 2:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-14 12:51 [PATCH] scsi: The supplement for the arithmetic of iomem of the Type_B Adapter of arcmsr nickcheng
2008-03-14 20:03 ` Andrew Morton
2008-03-14 20:26 ` James Bottomley
2008-03-17 2:08 ` [PATCH] scsi: The supplement for the arithmetic of iomem ofthe " nickcheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox