[PATCH] [SCSI] pm80xx : no need for tag allocation when issuing the command of unregistering device

[PATCH] [SCSI] pm80xx : no need for tag allocation when issuing the command of unregistering device

[XinHong Zhu]

In function pm8001_dev_gone_notify require a tag from bitmap resource and later don't free tag resource .So tag resource will be consume fully and following request can not be execed because of lack of tags . But in the function don't need use any tag to issue command of unregistering device .

Signed-off-by: XinHong Zhu <zxh3737@163.com>
---
 drivers/scsi/pm8001/pm8001_sas.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
index f50ac44..ba3088c 100644
--- a/drivers/scsi/pm8001/pm8001_sas.c
+++ b/drivers/scsi/pm8001/pm8001_sas.c
@@ -865,13 +865,11 @@ ex_err:
 static void pm8001_dev_gone_notify(struct domain_device *dev)
 {
 	unsigned long flags = 0;
-	u32 tag;
 	struct pm8001_hba_info *pm8001_ha;
 	struct pm8001_device *pm8001_dev = dev->lldd_dev;
 
 	pm8001_ha = pm8001_find_ha_by_dev(dev);
 	spin_lock_irqsave(&pm8001_ha->lock, flags);
-	pm8001_tag_alloc(pm8001_ha, &tag);
 	if (pm8001_dev) {
 		u32 device_id = pm8001_dev->device_id;
 
-- 
1.7.9

RE: [PATCH] [SCSI] pm80xx : no need for tag allocation when issuing the command of unregistering device

[lindar_liu]

On Thu, 2014-02-13 at 12:00 PM, XinHong Zhu wrote: 
> In function pm8001_dev_gone_notify require a tag from bitmap resource and
> later don't free tag resource .So tag resource will be consume fully and
> following request can not be execed because of lack of tags . But in the
> function don't need use any tag to issue command of unregistering device .
> 
> Signed-off-by: XinHong Zhu <zxh3737@163.com>
> ---
>  drivers/scsi/pm8001/pm8001_sas.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c
> b/drivers/scsi/pm8001/pm8001_sas.c
> index f50ac44..ba3088c 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -865,13 +865,11 @@ ex_err:
>  static void pm8001_dev_gone_notify(struct domain_device *dev)  {
>  	unsigned long flags = 0;
> -	u32 tag;
>  	struct pm8001_hba_info *pm8001_ha;
>  	struct pm8001_device *pm8001_dev = dev->lldd_dev;
> 
>  	pm8001_ha = pm8001_find_ha_by_dev(dev);
>  	spin_lock_irqsave(&pm8001_ha->lock, flags);
> -	pm8001_tag_alloc(pm8001_ha, &tag);
>  	if (pm8001_dev) {
>  		u32 device_id = pm8001_dev->device_id;
> 

Thanks for fix.
Acked-by: Lindar Liu <lindar_liu@usish.com>

> --
> 1.7.9