[PATCH 2.4] sym53c8xx_2 sniff inquiry fix

[PATCH 2.4] sym53c8xx_2 sniff inquiry fix

[Tony Battersby]

This is a resend of http://marc.theaimsgroup.com/?l=linux-scsi&m=108117878914404&w=2

The sym53c8xx_2 driver in lk 2.4.x is unmaintained.  This is a backported fix
from lk 2.6.x for a problem with sniffing inquiry data incorrectly resulting
in Ultra 160 negotiation being disabled for some devices.  Please apply.

--- linux-2.4.26-vanilla/drivers/scsi/sym53c8xx_2/sym_misc.c	Fri Nov  9 18:22:54 2001
+++ linux-2.4.26-asp/drivers/scsi/sym53c8xx_2/sym_misc.c	Wed Apr 28 14:02:41 2004
@@ -315,7 +315,7 @@
 	 */
 	inq_byte56 = tp->inq_byte56;
 	if (inq_version >= 4 && inq_len > 56)
-		tp->inq_byte56 = inq_data[56];
+		inq_byte56 = inq_data[56];
 #if 0
 printf("XXXXXX [%d] inq_version=%x inq_byte7=%x inq_byte56=%x XXXXX\n",
 	inq_len, inq_version, inq_byte7, inq_byte56);


Anthony J. Battersby
Cybernetics

[PATCH 2.4] sym53c8xx_2 sniff inquiry fix

[Tony Battersby]

The following patch fixes a problem where sym53c8xx_2 always sniffs a
value of 0x00 for inquiry byte 56, which breaks 160 MB/s negotiations.

I am working with lk 2.4.x; I don't know if this needs to be applied to
lk 2.6.x also.

--- drivers/scsi/sym53c8xx_2/sym_misc.c.orig	Mon Apr  5 11:03:28 2004
+++ drivers/scsi/sym53c8xx_2/sym_misc.c	Mon Apr  5 11:03:38 2004
@@ -315,7 +315,7 @@
 	 */
 	inq_byte56 = tp->inq_byte56;
 	if (inq_version >= 4 && inq_len > 56)
-		tp->inq_byte56 = inq_data[56];
+		inq_byte56 = inq_data[56];
 #if 0
 printf("XXXXXX [%d] inq_version=%x inq_byte7=%x inq_byte56=%x XXXXX\n",
 	inq_len, inq_version, inq_byte7, inq_byte56);



Anthony J. Battersby
Cybernetics

Re: [PATCH 2.4] sym53c8xx_2 sniff inquiry fix

[Matthew Wilcox]

On Mon, Apr 05, 2004 at 11:24:13AM -0400, Tony Battersby wrote:
> The following patch fixes a problem where sym53c8xx_2 always sniffs a
> value of 0x00 for inquiry byte 56, which breaks 160 MB/s negotiations.
> 
> I am working with lk 2.4.x; I don't know if this needs to be applied to
> lk 2.6.x also.

2.6 already has this fix; I only maintain 2.6 -- the 2.4 sym drivers
are unmaintained.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain