Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Martin Wilck <mwilck@suse.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Sachin Sant <sachinp@linux.ibm.com>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] scsi: alua: Fix alua_rtpg_queue()
Date: Thu, 17 Nov 2022 09:57:26 -0800	[thread overview]
Message-ID: <06a82972-75d6-b4cd-978b-29c10e4ca991@acm.org> (raw)
In-Reply-To: <2063a6a55bbbccd43ccdde0c687e27e39362286c.camel@suse.com>

On 11/16/22 23:03, Martin Wilck wrote:
> On Wed, 2022-11-16 at 13:22 -0800, Bart Van Assche wrote:
>> On 11/16/22 02:32, Martin Wilck wrote:
>>
>>
>> [...]
>>
>> Although I like the approach of this patch, how about the
>> implementation below?
>> I think the implementation below is a little cleaner but that might
>> be subjective ...
>>
> 
> Fine with me, absolutely, and indeed better than mine. I don't quite
> understand the last hook - sdev->handler_data isn't protected by rcu in
> any way, is it? But that doesn't matter much.

Hi Martin,

I plan to leave out the sdev->handler_data assignment change and to follow
the approach from your patch for the sdev->handler_data pointer (check
whether or not it is NULL) since I'm no longer sure that the change I
proposed is safe.

Thanks,

Bart.


  reply	other threads:[~2022-11-17 17:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15 22:49 [PATCH] scsi: alua: Fix alua_rtpg_queue() Bart Van Assche
2022-11-16 10:32 ` Martin Wilck
2022-11-16 21:22   ` Bart Van Assche
2022-11-17  7:03     ` Martin Wilck
2022-11-17 17:57       ` Bart Van Assche [this message]
2022-11-17 17:57 ` Benjamin Block

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06a82972-75d6-b4cd-978b-29c10e4ca991@acm.org \
    --to=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mwilck@suse.com \
    --cc=sachinp@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox