Re: [PATCH v4 06/29] scsi: core: Extend the scsi_execute_cmd() functionality

[Bart Van Assche <bvanassche@acm.org>]

On 9/12/25 1:03 PM, michael.christie@oracle.com wrote:
> On 9/12/25 1:21 PM, Bart Van Assche wrote:
>> +	if (cmd) {
>> +		scmd->cmd_len = COMMAND_SIZE(cmd[0]);
>> +		memcpy(scmd->cmnd, cmd, scmd->cmd_len);
>> +	}
>> +	if (args->init_cmd)
>> +		args->init_cmd(scmd, args);
> 
> I didn't follow all the reserved tag discussion so this might be a
> duplicate question. What will you do in the callout?
> 
> For these types of commands is the scsi_host_template->init_cmd_priv
> callout not called, or not called at the right time, or do you want to
> do special case initialization?

Hi Mike,

The scsi_execute_cmd() @args pointer is not passed to the SCSI host
template .init_cmd_priv callback. There are several examples in patch
29/29 where that pointer is essential at initialization time.

Patch 29/29 uses scsi_execute_cmd() to submit non-SCSI commands to a UFS
device.

Thanks,

Bart.