From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <quic_cang@quicinc.com>, Rohit Ner <rohitner@google.com>,
Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Avri Altman <avri.altman@wdc.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: Fix setup_xfer_req invocation
Date: Wed, 21 Feb 2024 09:55:06 -0800 [thread overview]
Message-ID: <0f959cca-ad29-4b8b-966d-55eb37156ef8@acm.org> (raw)
In-Reply-To: <c7635c10-1724-4db5-9568-d554e1c64f72@quicinc.com>
On 2/21/24 01:13, Can Guo wrote:
> I am going to push some BUG fixes for Qualcomm UFSHCI MCQ engine, one of
> which would count on a vops in ufshcd_send_command(). My original plan
> was to add a new vops.mcq_setup_xfer_req() to differentiate from the
> existing one used in legacy mode. But if Rohit moves the existing
> .setup_xfer_req() up, I can use it instead of introducing the new one.
Hi Can,
If an if-statement can be avoided in the hot path by introducing a new
callback pointer for MCQ code then I prefer the approach of introducing
a new callback instead of moving the setup_xfer_req() call.
Thanks,
Bart.
next prev parent reply other threads:[~2024-02-21 17:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 9:08 [PATCH] scsi: ufs: core: Fix setup_xfer_req invocation Rohit Ner
2024-02-20 17:21 ` Bart Van Assche
[not found] ` <CAGt9f=Qd8P4OUuT=KJQqpwJPYVB7zeCJjWn_4CTiXWce6ZRERg@mail.gmail.com>
2024-02-20 18:19 ` Bart Van Assche
2024-02-21 9:13 ` Can Guo
2024-02-21 17:55 ` Bart Van Assche [this message]
2024-02-22 2:05 ` Can Guo
2024-02-22 3:09 ` Bart Van Assche
2024-02-22 8:27 ` Rohit Ner
2024-02-22 15:25 ` Bart Van Assche
2025-01-07 10:23 ` Rohit Ner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f959cca-ad29-4b8b-966d-55eb37156ef8@acm.org \
--to=bvanassche@acm.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=rohitner@google.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox