public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* is there a clean way to disable a scsi timer
@ 2002-09-27  8:24 Jeremy Higdon
  2002-09-27  8:29 ` Jeremy Higdon
  0 siblings, 1 reply; 6+ messages in thread
From: Jeremy Higdon @ 2002-09-27  8:24 UTC (permalink / raw)
  To: linux-scsi

I have a host driver that does its own timeout and error handling.  Is there
a clean way to disable the midlayer timeout handling?  It appears that I
can just call scsi_disable_timer() from the queuecommand function, but
I'd prefer something less nasty.

thanks

jeremy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: is there a clean way to disable a scsi timer
  2002-09-27  8:24 is there a clean way to disable a scsi timer Jeremy Higdon
@ 2002-09-27  8:29 ` Jeremy Higdon
  0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Higdon @ 2002-09-27  8:29 UTC (permalink / raw)
  To: linux-scsi

Misremembered the name -- sorry.

s/scsi_disable_timer/scsi_delete_timer/

On Sep 27,  1:24am, Jeremy Higdon wrote:
> 
> I have a host driver that does its own timeout and error handling.  Is there
> a clean way to disable the midlayer timeout handling?  It appears that I
> can just call scsi_disable_timer() from the queuecommand function, but
> I'd prefer something less nasty.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: is there a clean way to disable a scsi timer
@ 2002-09-27 15:26 Infante, Jon
  0 siblings, 0 replies; 6+ messages in thread
From: Infante, Jon @ 2002-09-27 15:26 UTC (permalink / raw)
  To: 'Jeremy Higdon', linux-scsi

I do my own timeout handling as well. My queuecommand does
scsi_delete_timer() just as you suggested. However, just to be safe, I also
do a scsi_add_timer() in my iodone routine just before I call
cmnd->scsi_done(cmnd) to put things back the way they were.

Jon Infante


-----Original Message-----
From: Jeremy Higdon [mailto:jeremy@classic.engr.sgi.com]
Sent: Friday, September 27, 2002 1:30 AM
To: linux-scsi@vger.kernel.org
Subject: Re: is there a clean way to disable a scsi timer


Misremembered the name -- sorry.

s/scsi_disable_timer/scsi_delete_timer/

On Sep 27,  1:24am, Jeremy Higdon wrote:
> 
> I have a host driver that does its own timeout and error handling.  Is
there
> a clean way to disable the midlayer timeout handling?  It appears that I
> can just call scsi_disable_timer() from the queuecommand function, but
> I'd prefer something less nasty.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: is there a clean way to disable a scsi timer
@ 2002-09-28 15:47 Heinz, Michael
  2002-10-04  1:15 ` Jeremy Higdon
  0 siblings, 1 reply; 6+ messages in thread
From: Heinz, Michael @ 2002-09-28 15:47 UTC (permalink / raw)
  To: Infante, Jon, Jeremy Higdon, linux-scsi

Jon, Jeremy:

What is the intent in having the device driver do timeout handling? I ask because I've run into some issues with the midlayer timeouts not always working correctly and I've been thinking about implementing timeout processing in my driver. Was that the issue you had or was it something else?

--
Michael Heinz
Staff Software Engineer
Infinicon Systems, Inc.
http://www.infiniconsys.com 

> -----Original Message-----
> From: Infante, Jon [mailto:Jon.Infante@Emulex.Com]
> Sent: Friday, September 27, 2002 11:27 AM
> To: 'Jeremy Higdon'; linux-scsi@vger.kernel.org
> Subject: RE: is there a clean way to disable a scsi timer
> 
> 
> I do my own timeout handling as well. My queuecommand does
> scsi_delete_timer() just as you suggested. However, just to 
> be safe, I also
> do a scsi_add_timer() in my iodone routine just before I call
> cmnd->scsi_done(cmnd) to put things back the way they were.
> 
> Jon Infante
> 
> 
> -----Original Message-----
> From: Jeremy Higdon [mailto:jeremy@classic.engr.sgi.com]
> Sent: Friday, September 27, 2002 1:30 AM
> To: linux-scsi@vger.kernel.org
> Subject: Re: is there a clean way to disable a scsi timer
> 
> 
> Misremembered the name -- sorry.
> 
> s/scsi_disable_timer/scsi_delete_timer/
> 
> On Sep 27,  1:24am, Jeremy Higdon wrote:
> > 
> > I have a host driver that does its own timeout and error 
> handling.  Is
> there
> > a clean way to disable the midlayer timeout handling?  It 
> appears that I
> > can just call scsi_disable_timer() from the queuecommand 
> function, but
> > I'd prefer something less nasty.
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: is there a clean way to disable a scsi timer
@ 2002-09-30 18:31 Infante, Jon
  0 siblings, 0 replies; 6+ messages in thread
From: Infante, Jon @ 2002-09-30 18:31 UTC (permalink / raw)
  To: 'Heinz, Michael', Jeremy Higdon, linux-scsi

Michael,

I have a fibre channel driver, my issues included:

1) A device could disappear for > SD_TIMEOUT, then come back.
2) A fibre channel fabric has some input into what the timeout for a command
should be. Therefore my driver handles timing out all commands.

Back when the driver was developed, I noticed if SD_TIMEOUT did expire, the
system would hang / not recover properly.
Jon


-----Original Message-----
From: Heinz, Michael [mailto:mheinz@infiniconsys.com]
Sent: Saturday, September 28, 2002 8:48 AM
To: Infante, Jon; Jeremy Higdon; linux-scsi@vger.kernel.org
Subject: RE: is there a clean way to disable a scsi timer


Jon, Jeremy:

What is the intent in having the device driver do timeout handling? I ask
because I've run into some issues with the midlayer timeouts not always
working correctly and I've been thinking about implementing timeout
processing in my driver. Was that the issue you had or was it something
else?

--
Michael Heinz
Staff Software Engineer
Infinicon Systems, Inc.
http://www.infiniconsys.com 

> -----Original Message-----
> From: Infante, Jon [mailto:Jon.Infante@Emulex.Com]
> Sent: Friday, September 27, 2002 11:27 AM
> To: 'Jeremy Higdon'; linux-scsi@vger.kernel.org
> Subject: RE: is there a clean way to disable a scsi timer
> 
> 
> I do my own timeout handling as well. My queuecommand does
> scsi_delete_timer() just as you suggested. However, just to 
> be safe, I also
> do a scsi_add_timer() in my iodone routine just before I call
> cmnd->scsi_done(cmnd) to put things back the way they were.
> 
> Jon Infante
> 
> 
> -----Original Message-----
> From: Jeremy Higdon [mailto:jeremy@classic.engr.sgi.com]
> Sent: Friday, September 27, 2002 1:30 AM
> To: linux-scsi@vger.kernel.org
> Subject: Re: is there a clean way to disable a scsi timer
> 
> 
> Misremembered the name -- sorry.
> 
> s/scsi_disable_timer/scsi_delete_timer/
> 
> On Sep 27,  1:24am, Jeremy Higdon wrote:
> > 
> > I have a host driver that does its own timeout and error 
> handling.  Is
> there
> > a clean way to disable the midlayer timeout handling?  It 
> appears that I
> > can just call scsi_disable_timer() from the queuecommand 
> function, but
> > I'd prefer something less nasty.
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: is there a clean way to disable a scsi timer
  2002-09-28 15:47 Heinz, Michael
@ 2002-10-04  1:15 ` Jeremy Higdon
  0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Higdon @ 2002-10-04  1:15 UTC (permalink / raw)
  To: Heinz, Michael, Infante, Jon, linux-scsi

On Sep 28, 11:47am, Heinz, Michael wrote:
> 
> Jon, Jeremy:
> 
> What is the intent in having the device driver do timeout handling? I ask because I've run into some issues with the midlayer timeouts not always working correctly and I've been thinking about implementing timeout processing in my driver. Was that the issue you had or was it something else?
> 
> --
> Michael Heinz
> Staff Software Engineer
> Infinicon Systems, Inc.
> http://www.infiniconsys.com 

In my case, I'm trying to insert something under the mid-layer,
in which all timeouts are handled underneath.

Also, in some cases with Fibrechannel, such as a loss of signal, or
device disappearance, we want to give the device more time to return.

jeremy

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2002-10-04  1:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-09-27  8:24 is there a clean way to disable a scsi timer Jeremy Higdon
2002-09-27  8:29 ` Jeremy Higdon
  -- strict thread matches above, loose matches on Subject: below --
2002-09-27 15:26 Infante, Jon
2002-09-28 15:47 Heinz, Michael
2002-10-04  1:15 ` Jeremy Higdon
2002-09-30 18:31 Infante, Jon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox