public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Mukker, Atul" <Atulm@lsil.com>
Cc: 'Christoph Hellwig' <hch@infradead.org>,
	"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: RE: [ANNOUNCE]: megaraid driver version 2.20.0.1
Date: 06 Jul 2004 15:56:32 -0500	[thread overview]
Message-ID: <1089147398.2188.689.camel@mulgrave> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E57033BC826@exa-atlanta>

On Tue, 2004-07-06 at 13:32, Mukker, Atul wrote:
> > The biggest structural issue still seems to be the pending queue.  It
> > looks to me like the driver could be nicely simplified if you 
> > got rid of
> > it and simply relied on returning SCSI_MLQUEUE_HOST_BUSY from
> > queeucommand().  You'd still get the queue restart almost from the ISR
> This is a very good suggestion and I would be more than willing to include
> in the driver code. Only one concern though, there are other instances also
> when we need to stop sending commands to the controllers, but not
> necessarily stop getting commands from mid-layer. E.g., in case of delete
> drive operation, driver has to wait till all outstanding commands to the
> controller are complete, before issuing drive deletion command. In this
> situation, having a pending list seems natural.

We have this type of functionality already in the scsi_device_quiesce()
interface.  It will not return until all normal commands have completed
(specials and error handling are still allowed).  It was designed for
Domain Validation, but it sounds like you could use it as well.

James



  reply	other threads:[~2004-07-06 20:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-06 18:32 [ANNOUNCE]: megaraid driver version 2.20.0.1 Mukker, Atul
2004-07-06 20:56 ` James Bottomley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-07-21 13:48 Mukker, Atul
2004-07-21 17:06 ` James Bottomley
2004-07-20 21:21 Mukker, Atul
2004-07-20 21:56 ` James Bottomley
2004-06-26  0:55 Mukker, Atul
2004-07-06 14:46 ` James Bottomley
2004-06-25  9:07 Mukker, Atul
2004-06-25  1:07 Mukker, Atul
2004-06-25  8:13 ` 'Christoph Hellwig'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1089147398.2188.689.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=Atulm@lsil.com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox